New SystemProperties logging global changes #25569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dmatej
commented
Jun 18, 2025
dmatej
commented
- Also deleted unused GFSystem class
- In several cases I have noticed that some values are set repeatedly or even to different values which can cause some fragility (ordering, race conditions, surprises, etc).
- This solution is not global, affects just classes in this project, but even that is useful.
- Java doesn't offer anything like this, it is just possible to print system properties using jcmd or inside JVM.
dmatej
force-pushed
the
systempropertieslog
branch
from
342ee03 to
be97644
Compare
dmatej
force-pushed
the
systempropertieslog
branch
from
be97644 to
c0cf28a
Compare
Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
- Also deleted unused GFSystem class Signed-off-by: David Matějček <[email protected]>
dmatej
force-pushed
the
systempropertieslog
branch
2 times, most recently
from
63c02c8 to
ef15edb
Compare
pzygielo
reviewed
Jun 21, 2025
| @@ -125,10 +126,10 @@ public DerbyControl(final String derbyCommand, final String derbyHost, final Str | |||
|
|
|||
| // Do not set derby.system.home if derbyHome is empty | |||
| if (!isEmpty(derbyHome)) { | |||
| System.setProperty("derby.system.home", derbyHome); | |||
| setProperty("derby.system.home", derbyHome, true); | |||
There was a problem hiding this comment.
With all usages updated, could we have setProperty(String, String), that would default the 3rd parameter to true?
There was a problem hiding this comment.
I wanted to force decision if it should or should not overwrite existing value - which is quite important. Correctly no such events should ever happen, but it is not always true.
arjantijms
approved these changes
Jun 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.