This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Change some trimming functions to subshells#31
Open
augustobmoura wants to merge 1 commit intodylanaraps:masterfrom
Open
Change some trimming functions to subshells#31augustobmoura wants to merge 1 commit intodylanaraps:masterfrom
augustobmoura wants to merge 1 commit intodylanaraps:masterfrom
Conversation
to prevent options overriding
Author
|
Kinda solves #7 too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can have the situation that shell options are already unset, in that case we actually change them to setted. The correct way of preventing shell options overriding is using a subshell, because all the functions that use
setare only printing the result the subshell works like a charm.Also we can remove the resetting of options and env vars at the end of the functions