Skip to content

Improve fish file completion #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 20, 2025
Merged

Improve fish file completion #418

merged 3 commits into from
May 20, 2025

Conversation

gechr
Copy link
Contributor

@gechr gechr commented May 5, 2025

Copied the logic from curl.fish.

@ducaale
Copy link
Owner

ducaale commented May 5, 2025 •
edited
Loading

Since we auto-generate completion files, can you output this snippet in generation.rs? Thanks!

@gechr gechr force-pushed the gc/ttkrrwtxzmtu branch from 660c721 to 0e1543b Compare May 5, 2025 23:27
@gechr gechr force-pushed the gc/ttkrrwtxzmtu branch from 0e1543b to d17669f Compare May 5, 2025 23:29
@blyxxyz blyxxyz self-requested a review May 6, 2025 08:52
blyxxyz
blyxxyz approved these changes May 18, 2025
View reviewed changes
Copy link
Collaborator

@blyxxyz blyxxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thank you!

@ducaale ducaale merged commit 57783c3 into ducaale:master May 20, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blyxxyz blyxxyz blyxxyz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gechr @ducaale @blyxxyz