Skip to content

use interface's default implementation when creating proxy type #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

huoshan12345
Copy link
Collaborator

@huoshan12345 huoshan12345 commented Feb 28, 2025

@liuhaoyang
Copy link
Member

@huoshan12345 UT 没跑过,看一下?

@huoshan12345
Copy link
Collaborator Author

huoshan12345 commented Apr 7, 2025

@huoshan12345 UT 没跑过,看一下?

没过的原因貌似是需要donet 7.0的sdk

Testhost process for source(s) 'D:\a\AspectCore-Framework\AspectCore-Framework\tests\AspectCore.Extensions.Autofac.Test\bin\Release\net7.0\AspectCore.Extensions.Autofac.Test.dll' exited with error: You must install or update .NET to run this application.
App: D:\a\AspectCore-Framework\AspectCore-Framework\tests\AspectCore.Extensions.Autofac.Test\bin\Release\net7.0\testhost.exe
Architecture: x64
Framework: 'Microsoft.NETCore.App', version '7.0.0' (x64)
.NET location: C:\Program Files\dotnet
The following frameworks were found:
  6.0.5 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  6.0.26 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  6.0.36 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  6.0.37 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  8.0.6 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  8.0.13 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  9.0.2 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]

我看ci里只装了9.0的. 至于日志里显示有的6.x和8.x, 应该是镜像自带的, 可参考
注: 根据目前的镜像文档, windows-latest指的是windows-2022 (https://github.com/actions/runner-images)
https://github.com/actions/runner-images/blob/main/images/windows/Windows2022-Readme.md

NET Core Tools
.NET Core SDK: 6.0.136, 6.0.203, 6.0.321, 6.0.428, 8.0.114, 8.0.206, 8.0.310, 8.0.407, 9.0.104, 9.0.200, 9.0.202

其中确实也没有7.0

注: 上次master的ci过了是因为上次跑的并不是新的github action, 后者其实没触发

@liuhaoyang
Copy link
Member

.NET 7.0 属于不再支持的版本,https://dotnet.microsoft.com/zh-cn/download/dotnet
可以把 AspectCore.Extensions.Autofac.Test 的依赖升级掉吗

@liuhaoyang liuhaoyang merged commit d6fad08 into dotnetcore:master Apr 11, 2025
2 of 3 checks passed
@huoshan12345 huoshan12345 deleted the bugfix/issue-223-interface-default-methods-should-be-used branch April 11, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants