-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Make it possible to opt out of creating a dylib from the R2R output. #52480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
For the iOS SDK, we're going to create the dylib using our own logic, because our own logic supports executing remotely on a Mac.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request introduces the ability to opt out of creating a dylib (shared library) from Ready-to-Run (R2R) output for iOS SDK scenarios. The change allows the iOS SDK to use its own logic for dylib creation, particularly to support executing remotely on a Mac.
Changes:
- Added a new MSBuild property
PublishReadyToRunCreateSharedLibraryto control dylib creation - Modified the
_LinkReadyToRunMachOtarget condition to respect this opt-out property
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.CrossGen.targets
Show resolved
Hide resolved
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.CrossGen.targets
Show resolved
Hide resolved
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.CrossGen.targets
Show resolved
Hide resolved
jkoritzinsky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good. The error experience will be a little funky if someone sets this property without using the iOS SDK, but I think that's fine.
elinor-fung
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess setting the new property to false really only applies to macho container format right now, but I don't think it is worth adding anything to validate / error.
For the iOS SDK, we're going to create the dylib using our own logic, because
our own logic supports executing remotely on a Mac.