Skip to content

Conversation

@rolfbjarne
Copy link
Member

For the iOS SDK, we're going to create the dylib using our own logic, because
our own logic supports executing remotely on a Mac.

For the iOS SDK, we're going to create the dylib using our own logic, because
our own logic supports executing remotely on a Mac.
Copilot AI review requested due to automatic review settings January 15, 2026 12:31
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request introduces the ability to opt out of creating a dylib (shared library) from Ready-to-Run (R2R) output for iOS SDK scenarios. The change allows the iOS SDK to use its own logic for dylib creation, particularly to support executing remotely on a Mac.

Changes:

  • Added a new MSBuild property PublishReadyToRunCreateSharedLibrary to control dylib creation
  • Modified the _LinkReadyToRunMachO target condition to respect this opt-out property

Copy link
Member

@jkoritzinsky jkoritzinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good. The error experience will be a little funky if someone sets this property without using the iOS SDK, but I think that's fine.

Copy link
Member

@elinor-fung elinor-fung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess setting the new property to false really only applies to macho container format right now, but I don't think it is worth adding anything to validate / error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants