-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Remove 15 unused resource strings from CliCommandStrings #52448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Youssef1313 <[email protected]>
| <data name="CmdPackageDescription" xml:space="preserve"> | ||
| <value>The package reference to add. This can be in the form of just the package identifier, for example 'Newtonsoft.Json', or a package identifier and version separated by '@', for example '[email protected]'</value> | ||
| </data> | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot Avoid adding those blank lines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 5c16da6. Removed 5 blank lines that were introduced when deleting unused resources.
… resources Co-authored-by: Youssef1313 <[email protected]>
Co-authored-by: Youssef1313 <[email protected]>
| <data name="VerbTest" xml:space="preserve"> | ||
| <value>test</value> | ||
| </data> | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot Remove all blank lines that are added in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 7600733. Removed 6 double blank lines that were introduced when deleting unused resources.
| <source>Cannot use launch profile '{0}' because the launch settings file could not be located. Locations tried: | ||
| {1}</source> | ||
| <target state="translated">Nelze použít profil spouštění {0}, protože soubor nastavení spouštění nebyl nalezen. Vyzkoušená umístění: | ||
| <target state="new">Cannot use launch profile '{0}' because the launch settings file could not be located. Locations tried: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot Restore the translation back.
| <trans-unit id="InvalidVersionForWorkload"> | ||
| <source>Error parsing version '{1}' for workload manifest ID '{0}'</source> | ||
| <target state="new">Error parsing version '{1}' for workload manifest ID '{0}'</target> | ||
| <note /> | ||
| </trans-unit> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot Restore this in the original place it was in. This applies to all xlf files
Co-authored-by: Youssef1313 <[email protected]>
Co-authored-by: Youssef1313 <[email protected]>
…ptionCouldNotLocateALaunchSettingsFile in all xlf files Co-authored-by: Youssef1313 <[email protected]>
|
@copilot Run a build so that XLF files get updated, and commit the changes that will be automatically produced by the build. |
Co-authored-by: Youssef1313 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR performs a cleanup of unused resource strings in CliCommandStrings, removing 15 obsolete entries that are no longer referenced in the codebase. The cleanup reduces maintenance burden by eliminating dead code and simplifies the localization files.
Changes:
- Removed 15 unused resource strings from CliCommandStrings.resx
- Updated 13 .xlf localization files to remove corresponding translations
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Cli/dotnet/Commands/CliCommandStrings.resx | Removed 15 unused resource entries including package descriptions, verb names, conversion error messages, project convert messages, and tool command arguments |
| src/Cli/dotnet/Commands/xlf/CliCommandStrings.cs.xlf | Removed Czech translations for the 15 deleted resources |
| src/Cli/dotnet/Commands/xlf/CliCommandStrings.de.xlf | Removed German translations for the 15 deleted resources |
| src/Cli/dotnet/Commands/xlf/CliCommandStrings.es.xlf | Removed Spanish translations for the 15 deleted resources |
| src/Cli/dotnet/Commands/xlf/CliCommandStrings.fr.xlf | Removed French translations for the 15 deleted resources |
| src/Cli/dotnet/Commands/xlf/CliCommandStrings.it.xlf | Removed Italian translations for the 15 deleted resources |
| src/Cli/dotnet/Commands/xlf/CliCommandStrings.ja.xlf | Removed Japanese translations for the 15 deleted resources |
| src/Cli/dotnet/Commands/xlf/CliCommandStrings.ko.xlf | Removed Korean translations for the 15 deleted resources |
| src/Cli/dotnet/Commands/xlf/CliCommandStrings.pl.xlf | Removed Polish translations for the 15 deleted resources |
| src/Cli/dotnet/Commands/xlf/CliCommandStrings.pt-BR.xlf | Removed Brazilian Portuguese translations for the 15 deleted resources |
| src/Cli/dotnet/Commands/xlf/CliCommandStrings.ru.xlf | Removed Russian translations for the 15 deleted resources |
| src/Cli/dotnet/Commands/xlf/CliCommandStrings.tr.xlf | Removed Turkish translations for the 15 deleted resources |
| src/Cli/dotnet/Commands/xlf/CliCommandStrings.zh-Hans.xlf | Removed Simplified Chinese translations for the 15 deleted resources |
| src/Cli/dotnet/Commands/xlf/CliCommandStrings.zh-Hant.xlf | Removed Traditional Chinese translations for the 15 deleted resources |
Plan: Cleanup Unused Resources in CliCommandStrings
Analysis Complete
Resources Removed (15 total)
Resources Restored (2 total)
Localization Files
Code Review Feedback
Verification
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.