-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[StaticWebAssets] Add benchmarking infrastructure #49512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
javiercn
commented
Jun 20, 2025
- Adds a benchmark project so that we can start adding benchmarks for some of the tasks
Thanks for your PR, @@javiercn. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces benchmarking infrastructure for the StaticWebAssets SDK by adding a new benchmark project and wiring it into the solution and package management.
- Adds a console entry point and empty benchmark using BenchmarkDotNet
- Sets up a dedicated benchmarks project with templates and ignores
- Updates solution files and central package versions to include BenchmarkDotNet
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
src/StaticWebAssetsSdk/benchmarks/Program.cs | Entry point to run all benchmarks |
src/StaticWebAssetsSdk/benchmarks/Microsoft.NET.Sdk.StaticWebAssets.Benchmarks.csproj | Benchmark project setup |
src/StaticWebAssetsSdk/benchmarks/EmptyBenchmark.cs | Initial no-op benchmark |
src/StaticWebAssetsSdk/benchmarks/Directory.Build.template | Empty build template copied to props/targets |
src/StaticWebAssetsSdk/benchmarks/.gitignore | Ignore BenchmarkDotNet artifacts |
src/RazorSdk/Razor.slnf | Included benchmark project in solution filter |
sdk.slnx | Added benchmarks folder to solution structure |
eng/Versions.props | Defined BenchmarkDotNet package version |
Directory.Packages.props | Centralized BenchmarkDotNet package version |
Comments suppressed due to low confidence (1)
src/StaticWebAssetsSdk/benchmarks/Microsoft.NET.Sdk.StaticWebAssets.Benchmarks.csproj:4
- Verify that the TargetFramework 'net10.0' is supported by our build environment. If not, consider targeting a stable TFM like net7.0 or net8.0 to ensure compatibility.
<TargetFramework>net10.0</TargetFramework>
src/StaticWebAssetsSdk/benchmarks/Microsoft.NET.Sdk.StaticWebAssets.Benchmarks.csproj
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
* Updated TFMs * Added missing dependencies
68fefb5
to
e0362b2
Compare