Fix overriding HelpName in Parser.cs, set it explicitly instead #49423
+299
−42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #48817 and #49418.
There were only a couple commands where the option HelpName was overridden by EnsureHelpName, make those explicit instead and add a test that verifies all options comply.
Only one place remains that is still using EnsureHelpName, but it's not feasible to change this as we'd need to change every template:
sdk/src/Cli/Microsoft.TemplateEngine.Cli/Commands/create/InstantiateCommand.Help.cs
Lines 274 to 279 in 44798fa