JIT: Simplify ifdef for R2R needsIndirectionCellArg condition in morph#127624
Open
adamperlin wants to merge 1 commit intodotnet:mainfrom
Open
JIT: Simplify ifdef for R2R needsIndirectionCellArg condition in morph#127624adamperlin wants to merge 1 commit intodotnet:mainfrom
adamperlin wants to merge 1 commit intodotnet:mainfrom
Conversation
…h and update some comments
github-actions
Bot
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the FEATURE_READYTORUN / target-ifdef logic in CallArgs::AddFinalArgsAndDetermineABIInfo to make the needsIndirectionCellArg condition clearer and to better document the per-architecture behavior for passing the R2R indirection cell.
Changes:
- Replaces the prior
#ifndef TARGET_WASM+ nested#if TARGET_XARCHpattern with an explicit#ifdef TARGET_WASM/#elif TARGET_XARCH/#elsechain. - Makes the xarch “fast tailcall requires explicit indirection cell arg” rule explicit in the boolean initializer.
- Updates and reflows comments to more directly explain the rationale on WASM vs xarch vs other targets.
kg
approved these changes
May 1, 2026
jakobbotsch
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a bit of remaining feedback from #115375; Makes the condition for
needsIndirectionCellArgmore explicit in the ifdef chain and also moves and clarifies some comments.