Skip to content

Fix JsonValueConverter to handle array and object values in Dictionary<string, JsonValue> #115829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 4 commits into from

Fix invalid cast in JsonValueConverter

996f325
Select commit
Loading
Failed to load commit list.
Closed

Fix JsonValueConverter to handle array and object values in Dictionary<string, JsonValue> #115829

Fix invalid cast in JsonValueConverter
996f325
Select commit
Loading
Failed to load commit list.
Azure Pipelines / runtime (Build osx-x64 Debug Mono_MiniJIT_LibrariesTests) failed May 22, 2025 in 17m 10s

Build osx-x64 Debug Mono_MiniJIT_LibrariesTests failed

3 errors / 0 warnings

Annotations

Check failure on line 34 in src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Node/JsonValueConverter.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / runtime (Build osx-x64 Debug Mono_MiniJIT_LibrariesTests)

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Node/JsonValueConverter.cs#L34 

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Node/JsonValueConverter.cs(34,24): error CS0039: (NETCORE_ENGINEERING_TELEMETRY=Build) Cannot convert type 'System.Text.Json.Nodes.JsonObject' to 'System.Text.Json.Nodes.JsonValue' via a reference conversion, boxing conversion, unboxing conversion, wrapping conversion, or null type conversion

Check failure on line 39 in src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Node/JsonValueConverter.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / runtime (Build osx-x64 Debug Mono_MiniJIT_LibrariesTests)

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Node/JsonValueConverter.cs#L39 

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Node/JsonValueConverter.cs(39,24): error CS0039: (NETCORE_ENGINEERING_TELEMETRY=Build) Cannot convert type 'System.Text.Json.Nodes.JsonArray' to 'System.Text.Json.Nodes.JsonValue' via a reference conversion, boxing conversion, unboxing conversion, wrapping conversion, or null type conversion

Check failure on line 36 in src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Node/JsonValueConverter.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / runtime (Build osx-x64 Debug Mono_MiniJIT_LibrariesTests)

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Node/JsonValueConverter.cs#L36 

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Node/JsonValueConverter.cs(36,1): error SA1028: (NETCORE_ENGINEERING_TELEMETRY=Build) Code should not contain trailing whitespace (https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1028.md)
View more details on Azure Pipelines