Skip to content

Fix JsonValueConverter to handle array and object values in Dictionary<string, JsonValue> #115829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Move JsonValue deserialization tests to JsonNode namespace

b638b7f
Select commit
Loading
Failed to load commit list.
Draft

Fix JsonValueConverter to handle array and object values in Dictionary<string, JsonValue> #115829

Move JsonValue deserialization tests to JsonNode namespace
b638b7f
Select commit
Loading
Failed to load commit list.
Azure Pipelines / runtime failed May 21, 2025 in 46m 17s

Build #20250521.34 failed

141 errors / 0 warnings

Annotations

Check failure on line 34 in src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Node/JsonValueConverter.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / runtime

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Node/JsonValueConverter.cs#L34 

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Node/JsonValueConverter.cs(34,24): error CS0030: (NETCORE_ENGINEERING_TELEMETRY=Build) Cannot convert type 'System.Text.Json.Nodes.JsonObject' to 'System.Text.Json.Nodes.JsonValue'

Check failure on line 39 in src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Node/JsonValueConverter.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / runtime

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Node/JsonValueConverter.cs#L39 

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Node/JsonValueConverter.cs(39,24): error CS0030: (NETCORE_ENGINEERING_TELEMETRY=Build) Cannot convert type 'System.Text.Json.Nodes.JsonArray' to 'System.Text.Json.Nodes.JsonValue'

Check failure on line 36 in src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Node/JsonValueConverter.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / runtime

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Node/JsonValueConverter.cs#L36 

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Node/JsonValueConverter.cs(36,1): error SA1028: (NETCORE_ENGINEERING_TELEMETRY=Build) Code should not contain trailing whitespace (https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1028.md)

Check failure on line 34 in src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Node/JsonValueConverter.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / runtime

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Node/JsonValueConverter.cs#L34 

src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Node/JsonValueConverter.cs(34,24): error CS0030: (NETCORE_ENGINEERING_TELEMETRY=Build) Cannot convert type 'System.Text.Json.Nodes.JsonObject' to 'System.Text.Json.Nodes.JsonValue'
View more details on Azure Pipelines