WriteCodeFragment report name of attribute type instead of idx #11879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimaTian
approved these changes
May 26, 2025
SimaTian
reviewed
May 26, 2025
Co-authored-by: Tomas Bartonek <[email protected]>
AR-May
approved these changes
Jun 9, 2025
Member
AR-May
left a comment
AR-May
left a comment
There was a problem hiding this comment.
LGTM, just a small suggestion for better wording.
Co-authored-by: AR-May <[email protected]>
JanProvaznik
approved these changes
Jun 10, 2025
JanProvaznik
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Fix the issue #10007 the message not display the name of the attribute type whose definition it did not find
Context
When using the MSBuild with WriteCodeFragment in .csproj file, if the positional constructor parameters, use metadata names that resemble _Parameter1, _Parameter2 and the Attribute cannot found, the message display "Could not infer the type of parameter "#1" because the attribute type is unknown. The value will be treated as a string" instead of the name of the parameters"
Changes Made
Make the message display the name of the parameters instead of the index
Add a UnitTest for this case
Testing
Build a .csproj file with WriteCodeFragment and using an Attribute cannot found with the positional constructor parameters
Notes