[vs17.8] Merge tag v17.8.29 #11866
Merged
[vs17.8] Merge tag v17.8.29 #11866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DownloadFile should not rely on the remote server response headers. Unless the DestinationFileName task parameter is specified - let's just fallback to the request URI - which is as well the publicly documented behavior.
revert 10725 to unblock VS insertions by matching 17.8 VS versions.
We're doing a version bump so all branches have up-to-date opt-prof runs. [Opt-prof version](https://dev.azure.com/devdiv/_apps/hub/ms-vscs-artifact.build-tasks.drop-hub-group-explorer-hub?name=OptimizationData/DotNet-msbuild-Trusted/internal/vs17.8/20250416.5/11417138/1) ---- #### AI description (iteration 1) #### PR Classification Version update. #### PR Summary This pull request updates the version prefix in the project configuration. - `eng/Versions.props`: Updated `<VersionPrefix>` from `17.8.28` to `17.8.29`. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR merges tag v17.8.29 by bumping the MSBuild version, updating binding redirects and package versions, and refactoring file‐download logic.
- Refactored
DownloadFile.TryGetFileNameto take aUriinstead ofHttpResponseMessage - Updated binding redirects and codeBase entries for various assemblies to 7.x versions
- Bumped
<VersionPrefix>and dependency versions in props and XML baseline files
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Tasks/DownloadFile.cs | Changed TryGetFileName to use Uri; removed header-based filename lookup |
| src/MSBuild/app.config | Updated redirects to 7.x and inadvertently removed Microsoft.IO.Redist block |
| src/MSBuild/app.amd64.config | Updated redirects and codeBase versions to 7.x |
| eng/Versions.props | Bumped VersionPrefix and dependency version props |
| eng/Version.Details.xml | Updated dependency URIs, SHAs, and versions to 7.x |
| eng/SourceBuildPrebuiltBaseline.xml | Adjusted ignore patterns for System.Text.Json |
| eng/Packages.props | Removed System.Formats.Asn1 package reference |
Comments suppressed due to low confidence (3)
src/Tasks/DownloadFile.cs:312
- New fallback logic for filename extraction from URI should be covered by unit tests to validate behavior when destination is user-specified versus when falling back to
Path.GetFileName.
private bool TryGetFileName(Uri requestUri, out string filename)
src/Tasks/DownloadFile.cs:171
- The logic no longer attempts to read the Content-Disposition header, so filenames provided by the server will be ignored. Consider overloading or restoring header-based lookup if that behavior is still needed.
if (!TryGetFileName(uri, out string filename))
src/MSBuild/app.config:44
- The dependentAssembly block for
Microsoft.IO.Redistwas removed in this hunk. Re-add its<dependentAssembly>block to maintain the required binding redirect.
<bindingRedirect oldVersion="0.0.0.0-7.0.0.0" newVersion="7.0.0.0" />
Contributor
|
Hello! I noticed that you're targeting one of our servicing branches. Please consider updating the version. |
surayya-MS
force-pushed
the
msbuild/vs17.8
branch
from
ebf2e1a to
b1d27f0
Compare
rainersigwald
approved these changes
May 23, 2025
Member
rainersigwald
left a comment
rainersigwald
left a comment
There was a problem hiding this comment.
lgtm. Please merge, do not squash.
JanProvaznik
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Context
Changes Made
Testing
Notes