[.NET10] Add An API to SearchHandler so users can hide or show the softkeyboard #29600
+129
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…softkeyboard Added a UI Test
There was a problem hiding this comment.
Pull Request Overview
This PR introduces public methods to show and hide the soft keyboard via SearchHandler, wires those requests through platform handlers, and adds a UI scenario plus automated tests to verify the behavior.
- Exposed
ShowKeyboard()/HideKeyboard()onSearchHandlerwith corresponding internal events. - Updated iOS and Android appearance trackers to respond to new keyboard events.
- Added a sample Shell page and UI tests to validate keyboard visibility toggling.
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Controls/src/Core/Shell/SearchHandler.cs | Added ShowKeyboard()/HideKeyboard() methods and events. |
| src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/SearchHandlerAppearanceTracker.cs | Subscribed/unsubscribed to new keyboard events. |
| src/Controls/src/Core/Compatibility/Handlers/Shell/Android/SearchHandlerAppearanceTracker.cs | Subscribed/unsubscribed to new keyboard events. |
| src/Controls/tests/TestCases.HostApp/Issues/Issue29559.xaml | Added buttons wired to the new keyboard API. |
| src/Controls/tests/TestCases.HostApp/Issues/Issue29559.xaml.cs | Hooked up show/hide click handlers. |
| src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29559.cs | Added UI test for keyboard show/hide. |
| src/Controls/src/Core/PublicAPI/netstandard/PublicAPI.Unshipped.txt | Published the new API surface. |
| (and other PublicAPI.Unshipped.txt updates for each target) |
Comments suppressed due to low confidence (1)
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29559.cs:20
- [nitpick] The variable
IskeyboardVisibledoes not follow camelCase conventions; consider renaming toisKeyboardVisibleor similar.
bool IskeyboardVisible = App.IsKeyboardShown();
| @@ -0,0 +1,30 @@ | |||
| #if TEST_FAILS_ON_WINDOWS && TEST_FAILS_ON_CATALYST //In windows and mac catalyst, keyboard won't visible on focus and unfocus | |||
There was a problem hiding this comment.
The preprocessor condition uses && but should use || so the test is excluded on either Windows or Catalyst, not only when both are defined.
Suggested change
| #if TEST_FAILS_ON_WINDOWS && TEST_FAILS_ON_CATALYST //In windows and mac catalyst, keyboard won't visible on focus and unfocus | |
| #if TEST_FAILS_ON_WINDOWS || TEST_FAILS_ON_CATALYST //In windows and mac catalyst, keyboard won't visible on focus and unfocus |
Copilot uses AI. Check for mistakes.
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Issues Fixed
Fixes #29559