-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[Android] Input controls should not change keyboard visibility - UITest #29569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kubaflo
wants to merge
3
commits into
dotnet:main
Choose a base branch
from
kubaflo:test-29558
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
28 changes: 28 additions & 0 deletions
28
src/Controls/tests/TestCases.HostApp/Issues/Issue29558.xaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
<Shell xmlns:controls="clr-namespace:Maui.Controls.Sample.Issues" | ||
xmlns="http://schemas.microsoft.com/dotnet/2021/maui" | ||
xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml" | ||
x:Class="Maui.Controls.Sample.Issues.Issue29558"> | ||
<ShellContent | ||
Title="Home" | ||
Route="MainPage"> | ||
<ContentPage> | ||
<Shell.SearchHandler> | ||
<SearchHandler x:Name="searchHandler" | ||
Placeholder="searchHandler" | ||
Keyboard="Plain"/> | ||
</Shell.SearchHandler> | ||
<StackLayout> | ||
<Entry AutomationId="entry" | ||
x:Name="entry"/> | ||
<Editor AutomationId="editor" | ||
x:Name="editor"/> | ||
<SearchBar AutomationId="searchBar" | ||
x:Name="searchBar"/> | ||
<Button Text="Unfocus" | ||
Clicked="UnfocusButton_Clicked" | ||
AutomationId="unfocusButton"/> | ||
</StackLayout> | ||
</ContentPage> | ||
</ShellContent> | ||
</Shell> |
33 changes: 33 additions & 0 deletions
33
src/Controls/tests/TestCases.HostApp/Issues/Issue29558.xaml.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
namespace Maui.Controls.Sample.Issues; | ||
|
||
[Issue(IssueTracker.Github, 29558, "Input controls should not change keyboard visibility", PlatformAffected.Android)] | ||
public partial class Issue29558 : Shell | ||
{ | ||
int _action = 0; | ||
|
||
public Issue29558() | ||
{ | ||
InitializeComponent(); | ||
} | ||
|
||
private void UnfocusButton_Clicked(object sender, EventArgs e) | ||
{ | ||
switch (_action) | ||
{ | ||
case 0: | ||
searchHandler.Unfocus(); | ||
break; | ||
case 1: | ||
entry.Unfocus(); | ||
break; | ||
case 2: | ||
editor.Unfocus(); | ||
break; | ||
default: | ||
_action = 0; | ||
break; | ||
} | ||
|
||
_action = (_action + 1) % 3; | ||
} | ||
} |
37 changes: 37 additions & 0 deletions
37
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29558.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
#if ANDROID ///This test only runs on Android because UnFocus behavior differs across platforms: on Android the input view should remain visible after UnFocus, whereas on iOS it automatically hides. | ||
|
||
using NUnit.Framework; | ||
using UITest.Appium; | ||
using UITest.Core; | ||
|
||
namespace Microsoft.Maui.TestCases.Tests.Issues; | ||
|
||
public class Issue29558 : _IssuesUITest | ||
{ | ||
public Issue29558(TestDevice testDevice) : base(testDevice) { } | ||
|
||
public override string Issue => "Input controls should not change keyboard visibility"; | ||
|
||
[Test] | ||
[Category(UITestCategories.SoftInput)] | ||
public void Issue29558InputViewShouldNotHideOnUnfocusCall() | ||
{ | ||
bool isKeyboardVisible; | ||
App.WaitForElement("unfocusButton"); | ||
|
||
List<string> inputControls = ["entry", "editor", "searchBar", "searchHandler"]; | ||
foreach (var control in inputControls) | ||
{ | ||
App.Click(control); | ||
isKeyboardVisible = App.IsKeyboardShown(); | ||
Assert.That(isKeyboardVisible, Is.True); | ||
App.Click("unfocusButton"); | ||
isKeyboardVisible = App.IsKeyboardShown(); | ||
Assert.That(isKeyboardVisible, Is.True); | ||
App.DismissKeyboard(); | ||
isKeyboardVisible = App.IsKeyboardShown(); | ||
Assert.That(isKeyboardVisible, Is.False); | ||
} | ||
} | ||
} | ||
#endif |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.