[X] Protect some xmlns #28909
Closed
[X] Protect some xmlns #28909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephaneDelcroix
force-pushed
the
dev/stdelc/protectxmlns
branch
from
ddcb498 to
6613043
Compare
|
😉 |
MartyIX
reviewed
Apr 11, 2025
Comment on lines
+349
to
+352
| if (attribute.XmlNamespace.StartsWith("http://schemas.microsoft.com/", StringComparison.Ordinal) && | ||
| !attribute.AssemblyName.StartsWith("Microsoft", StringComparison.Ordinal) && | ||
| !attribute.AssemblyName.StartsWith("System", StringComparison.Ordinal) && | ||
| !attribute.AssemblyName.StartsWith("mscorlib", StringComparison.Ordinal)) |
There was a problem hiding this comment.
Looks this check is duplicated 3 times. Could you put that into a single, central place somewhere?
StephaneDelcroix
force-pushed
the
dev/stdelc/protectxmlns
branch
from
6613043 to
6140ca7
Compare
protect maui and x: xmlns from overloading. - fixes #28836
StephaneDelcroix
force-pushed
the
dev/stdelc/protectxmlns
branch
from
7849a4b to
49c2d2b
Compare
|
closing in favour of #29579 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
[X] Protect some xmlns
protect maui and x: xmlns from overloading.
Issues Fixed