Skip to content

[dotnet] Set ApplicationTitle correctly for desktop apps. Fixes #20615. #22913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 30, 2025

Conversation

rolfbjarne
Copy link
Member

  • Starting with .NET 10, make '$(ApplicationTitle)' control the name of the
    app bundle for desktop apps (the name of the app bundle isn't visible for
    mobile apps anywhere, so it doesn't matter for mobile apps). If not set, the
    default is "$(AssemblyName)" (like it was before).
  • Make the native executable name follow "$(AssemblyName)" instead of the app
    bundle name (since those two can now be different).
  • Make the CompileAppManifests target take a parameter specifying the name of
    the native executable, and write this as CFBundleExecutable in the app
    manifest.
  • Add a test.

Fixes #20615.

* Starting with .NET 10, make '$(ApplicationTitle)' control the name of the
  app bundle for desktop apps (the name of the app bundle isn't visible for
  mobile apps anywhere, so it doesn't matter for mobile apps). If not set, the
  default is "$(AssemblyName)" (like it was before).
* Make the native executable name follow "$(AssemblyName)" instead of the app
  bundle name (since those two can now be different).
* Make the CompileAppManifests target take a parameter specifying the name of
  the native executable, and write this as CFBundleExecutable in the app
  manifest.
* Add a test.

Fixes #20615.
@rolfbjarne rolfbjarne requested review from emaf and mauroa as code owners May 27, 2025 12:29
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #7555930] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 7555930de1413e0373d8e43510e70962576a23e1 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [PR Build #7555930] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 7555930de1413e0373d8e43510e70962576a23e1 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ [CI Build #7555930] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 7555930de1413e0373d8e43510e70962576a23e1 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

.NET ( No breaking changes )

✅ API diff vs stable

.NET ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 7555930de1413e0373d8e43510e70962576a23e1 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #7555930] Tests on macOS M1 - Mac Ventura (13) passed 💻

All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 7555930de1413e0373d8e43510e70962576a23e1 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #7555930] Tests on macOS M1 - Mac Monterey (12) passed 💻

All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 7555930de1413e0373d8e43510e70962576a23e1 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #7555930] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 7555930de1413e0373d8e43510e70962576a23e1 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build #7555930] Tests on macOS X64 - Mac Sonoma (14) passed 💻

All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 7555930de1413e0373d8e43510e70962576a23e1 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build #7555930] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 119 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 10 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 10 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 7555930de1413e0373d8e43510e70962576a23e1 [PR build]

@rolfbjarne rolfbjarne merged commit 86e61c6 into main May 30, 2025
44 checks passed
@rolfbjarne rolfbjarne deleted the dev/rolf/issue-20615 branch May 30, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS/Mac Catalyst] ApplicationTitle is not setting correctly
6 participants