[RGen] Generate the static class for the trampolines. #22890

mandel-macaque · 2025-05-23T18:44:50Z

This change just makes sure that the static class needed by the trampoline is correctly generated. The comment ignores the fact that the getters of the trampolines is incorrect, this is because we want to be able first to generate the helper classes.

The code generates the trampoline.g.cs file with the SD* classes but is missing the NID* ones which will be generated in comming PRs.

Upate the code generation of rgen to use the 'global::' allias based in the generator configuration. The tests classes have been updated to ensure that if we switch off the use of the alias, the tests do not need to be udpdated.

…er tracking.

…ppends with nfloat.

…ory.Dlfcn.cs Co-authored-by: Rolf Bjarne Kvinge <[email protected]>

This change just makes sure that the static class needed by the trampoline is correctly generated. The comment ignores the fact that the getters of the trampolines is incorrect, this is because we want to be able first to generate the helper classes. The code generates the trampoline.g.cs file with the SD* classes but is missing the NID* ones which will be generated in comming PRs.

Copilot

Pull Request Overview

This PR introduces the static class generation for trampolines while updating test classes and binding syntax to support the trampoline helper generation. Key changes include the addition of new trampoline properties in the test files, extended expected trampoline outputs and selectors, and updates to the TrampolineEmitter along with relevant documentation and known types.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
tests/rgen/Microsoft.Macios.Generator.Tests/Classes/Data/TrampolinePropertyTests.cs	Adds new trampoline properties and duplicate handler declarations for different delegate types
tests/rgen/Microsoft.Macios.Generator.Tests/Classes/Data/ExpectedTrampolinePropertyTestsTrampolines.cs	Extends generated trampoline delegates and exposes potential missing return in a delegate
tests/rgen/Microsoft.Macios.Generator.Tests/Classes/Data/ExpectedTrampolinePropertyTests.cs	Adds new selector handles and duplicate property definitions for trampoline callbacks
src/rgen/Microsoft.Macios.Generator/Emitters/TrampolineEmitter.cs	Implements static trampoline class and delegate emission logic
src/rgen/Microsoft.Macios.Generator/Emitters/Documentation.cs	Updates documentation methods for the trampoline static class
src/rgen/Microsoft.Macios.Generator/Emitters/BindingSyntaxFactory.KnownTypes.cs	Adds a new TypeSyntax for BlockLiteral

Comments suppressed due to low confidence (2)

tests/rgen/Microsoft.Macios.Generator.Tests/Classes/Data/ExpectedTrampolinePropertyTests.cs:285

There is a duplicate definition for the 'KernelRoiCallback' property which may lead to ambiguity. Consider consolidating these definitions or renaming one if they represent separate behaviors.

public partial global::CoreImage.CIKernelRoiCallback KernelRoiCallback

tests/rgen/Microsoft.Macios.Generator.Tests/Classes/Data/TrampolinePropertyTests.cs:46

There are duplicate export declarations for 'imageGeneratorCompletionHandler' with different delegate types. Ensure that each property export has a unique name or intended delegate type to avoid conflicts.

[Export<Property>("imageGeneratorCompletionHandler", ArgumentSemantic.Copy)]

Copilot · 2025-05-23T18:45:33Z

.../Microsoft.Macios.Generator.Tests/Classes/Data/ExpectedTrampolinePropertyTestsTrampolines.cs

+			}
+		}


The delegate SDCIKernelRoiCallback.Invoke is missing a return statement for the computed CGRect value. Add a 'return ret;' after calling the delegate to ensure the method returns a value.

Suggested change

}

}

return ret;

}

return global::CoreGraphics.CGRect.Empty;

vs-mobiletools-engineering-service2 · 2025-05-27T22:33:50Z

✅ [PR Build #969439b] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 969439b48e01b1af69b59e79f046a78084f269a4 [PR build]

vs-mobiletools-engineering-service2 · 2025-05-27T22:34:29Z

✅ [CI Build #c5d209d] Build passed (Build packages) ✅

Pipeline on Agent
Hash: c5d209d88f69dff61932542c218e10e0a6a1aedd [PR build]

vs-mobiletools-engineering-service2 · 2025-05-27T23:05:45Z

✅ [CI Build #c5d209d] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: c5d209d88f69dff61932542c218e10e0a6a1aedd [PR build]

vs-mobiletools-engineering-service2 · 2025-05-27T23:16:58Z

💻 [CI Build #c5d209d] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: c5d209d88f69dff61932542c218e10e0a6a1aedd [PR build]

vs-mobiletools-engineering-service2 · 2025-05-27T23:17:14Z

💻 [CI Build #c5d209d] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: c5d209d88f69dff61932542c218e10e0a6a1aedd [PR build]

vs-mobiletools-engineering-service2 · 2025-05-27T23:18:45Z

💻 [CI Build #c5d209d] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: c5d209d88f69dff61932542c218e10e0a6a1aedd [PR build]

vs-mobiletools-engineering-service2 · 2025-05-27T23:23:59Z

✅ API diff for current PR / commit

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 969439b48e01b1af69b59e79f046a78084f269a4 [PR build]

vs-mobiletools-engineering-service2 · 2025-05-28T02:20:09Z

💻 [CI Build #969439b] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 969439b48e01b1af69b59e79f046a78084f269a4 [PR build]

vs-mobiletools-engineering-service2 · 2025-05-28T03:03:14Z

🔥 [CI Build #c5d209d] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

0 tests crashed, 1 tests failed, 114 tests passed.

Failures

❌ generator tests

1 tests failed, 4 tests passed.

Roslyn Generator tests: Failed (Execution failed with exit code 1)

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: c5d209d88f69dff61932542c218e10e0a6a1aedd [PR build]

mandel-macaque and others added 8 commits May 22, 2025 21:23

[RGen] Use the 'global::' alias for all types.

0b67591

Upate the code generation of rgen to use the 'global::' allias based in the generator configuration. The tests classes have been updated to ensure that if we switch off the use of the alias, the tests do not need to be udpdated.

Auto-format source code

49916a3

Do not require to do the ToArray when trying to get the type expression.

0de9cd7

Move all the TypeSyntaxt of known types to the same location for easi…

55e372f

…er tracking.

Fix the case in which we need a using rename in the bindings. This ha…

0bfe739

…ppends with nfloat.

Auto-format source code

c0160ed

Update src/rgen/Microsoft.Macios.Generator/Emitters/BindingSyntaxFact…

4732f46

…ory.Dlfcn.cs Co-authored-by: Rolf Bjarne Kvinge <[email protected]>

mandel-macaque requested a review from Copilot May 23, 2025 18:45

Copilot AI reviewed May 23, 2025

View reviewed changes