feat: add zoom range support to keepCurrentZoomLevel option
#384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for array syntax in keepCurrentZoomLevel option to allow specifying a zoom range like [13, 18]. When the current zoom is within this range, the map only pans. Outside the range, it zooms normally. Changes: - Extract zoom-keeping logic into _shouldKeepCurrentZoom() helper - Support three modes: false (default), true (always), or [min, max] - Update README with usage examples and clarified maxZoom behavior This implements the feature originally requested in domoritz#246 and supersedes the stale PR domoritz#247 from 2019. The implementation uses a dedicated helper method for better testability and maintainability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for array syntax in
keepCurrentZoomLeveloption to allow specifying a zoom range like[13, 18]. When the current zoom is within this range, the map only pans. Outside the range, it zooms normally.Changes:
_shouldKeepCurrentZoom()helperfalse(default),true(always), or[min, max]maxZoombehaviorThis implements the feature originally requested in #246 and supersedes the stale PR #247 from 2019. This implementation uses a dedicated helper method for better testability and maintainability.