Skip to content
This repository was archived by the owner on Jul 18, 2025. It is now read-only.

Refactoring driver code base#4291

Open
guusvw wants to merge 11 commits intodocker-archive-public:masterfrom
kubermatic:feature/refactor-driver-clean
Open

Refactoring driver code base#4291
guusvw wants to merge 11 commits intodocker-archive-public:masterfrom
kubermatic:feature/refactor-driver-clean

Conversation

@guusvw
Copy link
Copy Markdown

@guusvw guusvw commented Oct 24, 2017

After looking through the code base of the driver implementation I recognized, that the approaches & styles of the different implementations are very differently.
That's just the first of some upcoming refactor PRs.

  • Add more consts for default values
  • Simplify return statements
  • remove unnecessary calls
  • try to get rid of magic strings
  • restructure interfaces

guusvw added 11 commits October 24, 2017 10:28
Signed-off-by: Guus van Weelden <guus@weelden.de>
then delete instance

Signed-off-by: Guus van Weelden <guus@weelden.de>
Signed-off-by: Guus van Weelden <guus@weelden.de>
Signed-off-by: Guus van Weelden <guus@weelden.de>
Signed-off-by: Guus van Weelden <guus@weelden.de>
Signed-off-by: Guus van Weelden <guus@weelden.de>
Signed-off-by: Guus van Weelden <guus@weelden.de>
Signed-off-by: Guus van Weelden <guus@weelden.de>
Signed-off-by: Guus van Weelden <guus@weelden.de>
Signed-off-by: Guus van Weelden <guus@weelden.de>
Signed-off-by: Guus van Weelden <guus@weelden.de>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant