chore: bump bubbles v0.18.0 => v0.21.0 #561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR bumps Bubbles to the newest version.
gh-dashhas been a few versions behind (v0.18.0 => v0.21.0).The reason I wanted to PR this is that I'm starting to use
gh-dashmore and more, maybe even considering daily-driving it. I'm constantly running into minor annoyances (hence my previous PR (#558)) and I found another one today: as it turns out, proper (GNU) readline support for input fields hasn't been around for that long in Bubbletea. Interactions with text inputs ingh-dashwill become a lot less annoying (especially since Bubbles v0.20.0 has support for focus/blur window events) after merging this.I'm sorry if my PRs are on the edge of being nitpicky. These are just small personal annoyances, but on the other hand, why not contribute the fix?