fix: mssql should only load data for the views specified by materialize views

[conoremclaughlin]

No description provided.

[svantevonerichsen6906]

Please don't litter the code base with debugging prints, and please do adhere to the formatting standard that is very much established in the entire Lisp language ecosystem. Can't review like this.

[conoremclaughlin]

Hi @svantevonerichsen6906, thanks for the comments. I wanted to get the PR up for anyone who found it useful before cleaning it up.

I've removed the debug statements and have changed the parentheses to follow more of Lisp's standards. Unfortunately it's been quite some time since I learned Lisp in Berkeley and Lisp doesn't have a good formatter, so this is about as far as I can go for formatting. If you can give me some more specifics I can address them! Otherwise I would run the formatter across the file. The original code's indentation formatting was also off. It's also specifically noted that this flow was untested by the author, so anything is an improvement over the untested / completely broken materialize views code path we currently have for MSSQL.

Thanks!

[conoremclaughlin]

Fixes #1551.

[conoremclaughlin]

Bumping this @svantevonerichsen6906. Thanks man!

[svantevonerichsen6906]

What I mean is: completely clean up the debugging alterations, and this is the indentation that should appear here:

(let* ((view-names (unless (eq :all materialize-views)
                     (mapcar #'matview-source-name materialize-views)))
       (including nil))
  (loop :for (schema-name . view-name) :in view-names
        :do (let* ((schema-name (or schema-name "dbo"))
                   (schema-entry (or
                                  (assoc schema-name including :test #'string=)
                                  (let ((new-entry (cons schema-name nil)))
                                    (push new-entry including)
                                    new-entry))))
              (push-to-end view-name (cdr schema-entry))))
  …)

I don't fully understand what's changed here yet, though