Improve resource dependencies & Add resource icons #2637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now they work again and correctly list and replace the files used by the character resource.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements/Fixes the _get_dependencies methods for timeline and character resources. This means you can now right click a timeline or character resource in the file system and use the "Edit Dependencies" option to see all the resources used by that file. For characters even the editing/replacing works.
To make this work in events, in the get_shortcode_paramaters() external references can now be marked.
I'm not sure if the timeline stuff has too big of a performance cost, as it needs to open the file to list the dependencies and I think godot does this whenever the file is saved. If it turns out this slows down big projects too much, we will have to reconsider this.
This also adds a new timeline icon (instead of using godots three-stripes icon) and sets the resource icon for characters and timelines (so they finally appear in the file system!!)