Skip to content

Conversation

@a-schur
Copy link
Contributor

@a-schur a-schur commented Dec 6, 2025

Tests for update-types, dependency-type, and exclude-patterns support in multi-ecosystem groups to validate the feature implemented in github/dependabot-api#7434.

Fixes: #13572

Test coverage:

  • update-types filtering (minor, patch)
  • dependency-type filtering (development, production)
  • exclude-patterns filtering
  • patterns combined with update-types
  • multi-directory scenarios
  • combined filter scenarios

What are you trying to accomplish?

Anything you want to highlight for special attention from reviewers?

How will you know you've accomplished your goal?

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@a-schur a-schur requested a review from jakecoffman December 6, 2025 00:16
@a-schur a-schur marked this pull request as ready for review December 6, 2025 00:17
@a-schur a-schur requested a review from a team as a code owner December 6, 2025 00:17
@jakecoffman jakecoffman requested a review from Copilot December 9, 2025 16:27
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds comprehensive end-to-end test coverage for multi-ecosystem grouped dependency updates, testing the filtering properties (update-types, dependency-type, and exclude-patterns) that were implemented in github/dependabot-api#7434. These tests validate that the multi-ecosystem update feature correctly applies various filters when grouping dependencies across different scenarios.

Key changes:

  • Six new test files covering different filtering scenarios in multi-ecosystem grouped updates
  • Tests verify update-types filtering, dependency-type filtering, exclude-patterns, and combinations thereof
  • Includes tests for both single and multi-directory scenarios

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
silent/tests/testdata/vu-multi-ecosystem-update-types.txt Tests update-types filtering (minor and patch) in multi-ecosystem groups
silent/tests/testdata/vu-multi-ecosystem-patterns-with-filters.txt Tests combining pattern matching with update-types filters
silent/tests/testdata/vu-multi-ecosystem-multidir-update-types.txt Tests update-types filtering across multiple directories
silent/tests/testdata/vu-multi-ecosystem-exclude-patterns.txt Tests exclude-patterns filtering in multi-ecosystem groups
silent/tests/testdata/vu-multi-ecosystem-dependency-type.txt Tests dependency-type filtering (development vs production)
silent/tests/testdata/vu-multi-ecosystem-combined-filters.txt Tests combining multiple filter types (dependency-type, update-types, exclude-patterns)

pavera
pavera previously approved these changes Dec 10, 2025
dependency-type: "development"
update-types:
- minor
- patch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would major always be excluded?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the update-types list only includes minor and patch, then major updates are excluded for that group. Only dependencies that qualify for minor or patch updates are handled; major updates will be ignored for this config.

@a-schur a-schur requested a review from rickreyhsig January 8, 2026 14:25
a-schur and others added 3 commits January 9, 2026 13:20
Tests for update-types, dependency-type, and exclude-patterns support
in multi-ecosystem groups to validate the feature implemented in
github/dependabot-api#7434.

Fixes: #13572

Test coverage:
- update-types filtering (minor, patch)
- dependency-type filtering (development, production)
- exclude-patterns filtering
- patterns combined with update-types
- multi-directory scenarios
- combined filter scenarios
@a-schur a-schur force-pushed the multi-ecosystem-group-filtering-tests branch from 96fc772 to fe945a4 Compare January 9, 2026 19:20
@a-schur a-schur merged commit cb2fa23 into main Jan 9, 2026
109 of 111 checks passed
@a-schur a-schur deleted the multi-ecosystem-group-filtering-tests branch January 9, 2026 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

multi-ecosystem groups does not work with update-types

4 participants