-
Notifications
You must be signed in to change notification settings - Fork 2.2k
fix: Fix invoker to work when using dataclass with from_dict but dataclass… #9434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… is already given
Pull Request Test Coverage Report for Build 15210934031Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
@vblagoje I'd also appreciate your review on this since you worked on ComponentTool in the past |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK but I would like if @vblagoje can review too
Related Issues
Proposed Changes:
Fix invoker to work when using dataclass with from_dict but dataclas is already given
Updated the
component_invoker
method to allow fully formed dataclass objects to pass through. Otherwise we silently remove the parameter value.Originally found by @bilgeyucel when creating an tool using Agent + ComponentTool and calling
How did you test it?
Notes for the reviewer
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
and added!
in case the PR includes breaking changes.