-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat: add component name and type to StreamingChunk
#9426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+135
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 15272575453Details
💛 - Coveralls |
Amnah199
commented
May 22, 2025
sjrl
reviewed
May 22, 2025
sjrl
reviewed
May 26, 2025
sjrl
reviewed
May 26, 2025
sjrl
reviewed
May 26, 2025
releasenotes/notes/add-component-info-dataclass-be115dee2fa50abd.yaml
Outdated
Show resolved
Hide resolved
sjrl
reviewed
May 26, 2025
sjrl
reviewed
May 26, 2025
sjrl
reviewed
May 26, 2025
sjrl
reviewed
May 26, 2025
sjrl
reviewed
May 26, 2025
sjrl
reviewed
May 26, 2025
…bd.yaml Co-authored-by: Sebastian Husch Lee <[email protected]>
…m/deepset-ai/haystack into component-info-in-streaming-chunk
sjrl
reviewed
May 27, 2025
Looking good! Just one last comment on using the |
sjrl
approved these changes
May 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
This was referenced May 27, 2025
This was referenced May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
StreamingChunk
(e.g.component_name
,component_type
,model_name
) #9359Proposed Changes:
component_name
for component instances added to pipelineComponentInfo
data class used byStreamingChunk
to stream information about the components.component_info
tostreaming_callback
How did you test it?
Notes for the reviewer
Once this PR is reviewed, we can update the ChatGenerators in core-integrations to stream component_info.
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
and added!
in case the PR includes breaking changes.