feat(langfuse): embedder, retriever and generator as obs. type #2497
+146
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
integration:langfuse
type:documentation
This was referenced Nov 8, 2025
Closed
Contributor
|
hey @vblagoje I'm assigning you since you have more context |
vblagoje
requested changes
Nov 10, 2025
Member
vblagoje
left a comment
vblagoje
left a comment
There was a problem hiding this comment.
Let's just make this one minor change if you agree. Lowers cognitive load quite a lot.
| elif context.operation_name == "haystack.agent.run": | ||
| return LangfuseSpan(self.tracer.start_as_current_observation(name=context.name, as_type="agent")) | ||
| elif context.component_type in _ALL_SUPPORTED_GENERATORS: | ||
| elif context.component_type and context.component_type.endswith("Retriever"): |
Member
There was a problem hiding this comment.
Looks good, I started this smell here, so let's please update it to something that's easier to read:
span_type = "span"
if context.component_type == "ToolInvoker":
span_type = "tool"
elif context.operation_name == "haystack.agent.run":
span_type = "agent"
elif context.component_type and context.component_type.endswith("Retriever"):
span_type = "retriever"
elif context.component_type and context.component_type.endswith("Embedder"):
span_type = "embedding"
elif context.component_type and context.component_type.endswith("Generator"):
span_type = "generation"
return LangfuseSpan(self.tracer.start_as_current_observation(name=context.name, as_type=span_type))
LMK wdyt
Contributor
Author
There was a problem hiding this comment.
You are right! Much better now.
vblagoje
approved these changes
Nov 11, 2025
Member
vblagoje
left a comment
vblagoje
left a comment
There was a problem hiding this comment.
ok looks gtg, thanks for this contrib @Hansehart, keep them coming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Remove hardcoded (chat) generator type checks from Langfuse tracer #2050
feat(langfuse): add cost and usage support for more generators and generally for embedders #2472
feat(langfuse): enhance trace capabilities by default with the types that langfuse offers #2473
Proposed Changes:
Adopting https://langfuse.com/docs/observability/features/observation-types for better observability. Langfuse types has been adopted where it makes sense. Beside better visual interaction, usage and cost tracking is for the appropriate types improved
How did you test it?
unit
Notes for the reviewer
Added embedder, generator and retriever. Also new logic for checking for generator type.
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.