fix: Use the new versions api to patch pipeline for overwrite #283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of the older put `<pipeline>/yaml` endpoint
Member
|
Thanks a lot @bglearning Looks good already, let's fix the failing tests, and it's good to go! |
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
Contributor
Author
|
@tstadel Updated the tests accordingly. Note: expected but tried out and the indexing update works fine ☑️ |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 17, 2025
* Use the new versions api to patch pipeline Instead of the older put `<pipeline>/yaml` endpoint * Update unit tests to align with the PipelineService overwrite update * Fix mypy issues in test_integration_pipeline_client.py
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Member
|
@bglearning pr looks good, integration tests are failing here: https://github.com/deepset-ai/deepset-cloud-sdk/actions/runs/19437916146/job/55613612329#step:3:491 |
Member
|
added the integration tests tag to run the tests in the PR |
Contributor
Author
|
@ArzelaAscoIi Updated it. I think can go back to the merge queue. |
Member
|
merging it! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of the older put
<pipeline>/yamlendpoint we switch to the<pipeline>/versions/<version-id>endpoint.Related Issues
Proposed Changes?
There is a new versions endpoint on the platform. So updating a pipeline involves patch request to that endpoint instead.
How did you test it?
Manual end-to-end.
And update to the unit tests.
Checklist