Skip to content

Conversation

@faymarie
Copy link
Contributor

@faymarie faymarie commented Jun 13, 2025

Related Issues

  • split pipeline client into sync and async clients to be better in line with the rest of of repo structure and documentation
  • adds new modules to README generation

Directory changes:

  • no more pipeline_client directory
  • created separate client for AsyncPipelineClient in async client directory
  • pipeline_client moved to sync_client directory, inherits for AsyncPipelineClient
  • pipeline modules moved to the top-level moduls
  • pipeline_service moved to service directory

Proposed Changes?

How did you test it?

Notes for the reviewer

Screenshots (optional)

Checklist

  • I have updated the referenced issue with new insights and changes
  • If this is a code change, I have added unit tests
  • I've used the conventional commit specification for my PR title
  • I updated the docstrings
  • If this is a code change, I added meaningful logs and prepared Datadog visualizations and alerts

@github-actions
Copy link

github-actions bot commented Jun 13, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  deepset_cloud_sdk
  __init__.py
  models.py
  deepset_cloud_sdk/_service
  pipeline_service.py
  deepset_cloud_sdk/workflows
  __init__.py
  deepset_cloud_sdk/workflows/async_client
  async_pipeline_client.py
  deepset_cloud_sdk/workflows/sync_client
  pipeline_client.py
Project Total  

This report was generated by python-coverage-comment-action

@faymarie faymarie marked this pull request as ready for review June 13, 2025 15:12
@faymarie faymarie requested a review from a team as a code owner June 13, 2025 15:12
@faymarie faymarie requested a review from tstadel June 13, 2025 15:12
@faymarie faymarie requested a review from ArzelaAscoIi June 13, 2025 15:22
Copy link
Member

@ArzelaAscoIi ArzelaAscoIi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nits around the inheritance/ naming.

already approving. I am also fine with doing it like this (reworking if required should be quickly doable if someone complains)

Copy link
Member

@ArzelaAscoIi ArzelaAscoIi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THank you!

@faymarie
Copy link
Contributor Author

Thanks for the hint of using composition. It's more straightforward indeed. Also renamed the method. @ArzelaAscoIi

@faymarie faymarie added this pull request to the merge queue Jun 16, 2025
Merged via the queue into main with commit 5824219 Jun 16, 2025
9 checks passed
@faymarie faymarie deleted the fix/restructure-pipeline-client branch June 16, 2025 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants