-
Notifications
You must be signed in to change notification settings - Fork 4
chore: separate pipeline client into sync and async clients #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
ArzelaAscoIi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some nits around the inheritance/ naming.
already approving. I am also fine with doing it like this (reworking if required should be quickly doable if someone complains)
ArzelaAscoIi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THank you!
|
Thanks for the hint of using composition. It's more straightforward indeed. Also renamed the method. @ArzelaAscoIi |
Related Issues
Directory changes:
Proposed Changes?
How did you test it?
Notes for the reviewer
Screenshots (optional)
Checklist