Skip to content

chore: drop content filter #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 22, 2024
Merged

chore: drop content filter #207

merged 7 commits into from
Oct 22, 2024

Conversation

@ArzelaAscoIi
Copy link
Member

@ArzelaAscoIi ArzelaAscoIi commented Oct 2, 2024 •
edited
Loading

Related Issues

  • deprecate content filter

Proposed Changes?

  • deprecate not longer supported and not used content filter
  • fix integration tests

Checklist

  • I have updated the referenced issue with new insights and changes
  • If this is a code change, I have added unit tests
  • I've used the conventional commit specification for my PR title
  • I updated the docstrings
  • If this is a code change, I added meaningful logs and prepared Datadog visualizations and alerts

@ArzelaAscoIi ArzelaAscoIi requested a review from wochinge October 21, 2024 16:41
@github-actions
Copy link

github-actions bot commented Oct 21, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  deepset_cloud_sdk
  cli.py
Project Total  

This report was generated by python-coverage-comment-action

wochinge
wochinge approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ArzelaAscoIi ArzelaAscoIi added this pull request to the merge queue Oct 22, 2024
Merged via the queue into main with commit 6998e82 Oct 22, 2024
10 checks passed
@ArzelaAscoIi ArzelaAscoIi deleted the chore/dropContentFIlter branch October 22, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@wochinge wochinge wochinge approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ArzelaAscoIi @wochinge