feat: DH-19489: Support structured Filters in Core Py client #7486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmao-denver
added
python
NoDocumentationNeeded
python-client
NoReleaseNotesNeeded
Contributor
No docs changes detected for 4d92477 |
jmao-denver
force-pushed
the
DH-19489-filters-core-py-client
branch
from
fd18265 to
bc3ad0b
Compare
jmao-denver
requested review from
chipkent,
cpwright and
rcaudy
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for structured Filter objects in the Deephaven Core Python client, allowing users to construct type-safe table filters programmatically instead of using only string-based filter expressions.
Key changes:
- New
filters.pymodule withFilterabstract base class and concrete implementations for comparison, logical, and pattern-matching operations - Support for datetime types (Python datetime, numpy datetime64, pandas Timestamp) in filter values
- Case-sensitivity control for string comparison operations
- Integration of Filter objects into Table.where() and Query.where() methods
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| py/client/pydeephaven/filters.py | New module implementing Filter classes and factory functions for creating structured filters |
| py/client/tests/test_filters.py | Comprehensive unit and integration tests for the filters module |
| py/client/pydeephaven/_table_ops.py | Added FilterOp class to handle structured Filter objects in table operations |
| py/client/pydeephaven/_table_interface.py | Updated where() method to accept both string and Filter objects |
| py/client/pydeephaven/table.py | Updated Table.where() signature to include Filter types |
| py/client/pydeephaven/query.py | Updated Query.where() signature to include Filter types |
| py/client/setup.py | Added pandas as a required dependency |
| py/client/requirements.txt | Added pandas to requirements |
Comments suppressed due to low confidence (1)
py/client/pydeephaven/filters.py:1
- The FilterOp class is defined in filters.py but should be in _table_ops.py based on the diff context. This appears to be a misplaced code block - the FilterOp class definition shown in the diff for _table_ops.py (lines 356-383) is the correct location.
#
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.