Conversation
…_VERSION environment variable from build step
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the GitHub Actions build-and-publish workflow to use a newer default Deephaven version via the global DH_VERSION env var, and simplifies the build job by removing a redundant step-level env assignment.
Changes:
- Bumped global
DH_VERSIONin the workflow from0.34.1to41.1. - Removed redundant
DH_VERSIONexport from theBuildstep env (relying on global env instead).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…t YAML parsing as float
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the build workflow configuration, specifically by updating the
DH_VERSIONenvironment variable and removing a redundant environment variable assignment in the build job.Dependency version update:
DH_VERSIONenvironment variable from0.34.1to41.1in.github/workflows/build-and-publish.ymlto ensure the workflow uses the latest version.Workflow simplification:
DH_VERSIONin the build job's environment, as it is now set globally.