Mostly complete conversion to 4.2.1 #188
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous PR #182 for this matter was lacking quite a bit of work.
This conversion fixes all of the compile-time errors, and a significant portion of run-time errors. From this, I think you should be able to make a working version of your own card game. It might work on earlier versions, but I'm only using stable for now.
Here's what still needs to be done, broken down into categories:
GUT
yield_for
andyield_to
are now deprecated and should be changed towait_for_signal
wait_seconds
.DEMO / BASE SCENES
REWRITES
super._ready()
Many issues stemmed from the fact that lifecycle functions no longer call their super version of those functions. The fix for this means that every derived class needs to usesuper._ready()
as the first line in their_ready()
, which also means that users will need to do that in their derived classes. Some way to rewrite these classes to prevent that would be nice for the end user.$VBC/Focus
is a PopUpPanel node. This node used to be a Control but is now a Window - which means there is no 'modulate' property. If we want to continue the soft fade in/out either a way using Window should be done, or it should be changed to a different node type. It might need a re-write with the change. Also note the effect on test_piles.gd:95class_name
of a script object. I think it would be able to simplify logic in a few places.SPECIFIC
These may or may not address other listed items
pre_sorted_order
is never given a valueis not
andis !
are not allowed in syntax). It can be fixed when 4.3 is releasedOTHER
@onready var _tween = create_tween()
not being in a function)There may be more things.
My intention is to keep working on it, but I wanted to share the "working" version for feedback and collaboration.