Mostly complete conversion to 4.2.1 #188

menaechmi · 2024-03-13T18:44:54Z

The previous PR #182 for this matter was lacking quite a bit of work.

This conversion fixes all of the compile-time errors, and a significant portion of run-time errors. From this, I think you should be able to make a working version of your own card game. It might work on earlier versions, but I'm only using stable for now.

Here's what still needs to be done, broken down into categories:

GUT

GUT GUI needs to be updated. GUT now expects you to use the gut tab in the editor, instead of a scene.
Many GUT tests fail on the Demo and in general. Without the GUI working, it is hard to tell which ones.
yield_for and yield_to are now deprecated and should be changed to wait_for_signal wait_seconds.
Maybe GUT should be a submodule?

DEMO / BASE SCENES

Main menu title text is wrong size
Library card and deck builder don't work as intended. Part of the issue is that PopUpPanels are no longer Controls but Windows.
Demo does not show cards. They're properly loaded into cfc.deck but never make it to the Scene Tree. They work properly in GUT tests.

REWRITES

Font handling (mostly in cardfront.gd) has changed. Instead of a font file copy for each use (which provides font.size that can be changed) Godot now uses a single FontFile with theme_fonts (and theme_override_font_size). Some if it is started.
super._ready() Many issues stemmed from the fact that lifecycle functions no longer call their super version of those functions. The fix for this means that every derived class needs to use super._ready() as the first line in their _ready(), which also means that users will need to do that in their derived classes. Some way to rewrite these classes to prevent that would be nice for the end user.
ViewPortCardFocus.gd:155:180 $VBC/Focus is a PopUpPanel node. This node used to be a Control but is now a Window - which means there is no 'modulate' property. If we want to continue the soft fade in/out either a way using Window should be done, or it should be changed to a different node type. It might need a re-write with the change. Also note the effect on test_piles.gd:95
Script.get_global_name will be exposed in 4.3 which should allow us to get the class_name of a script object. I think it would be able to simplify logic in a few places.
I mostly just wrote the tween logic to replace what already existed, but they could definitely use a re-write all over the place to take advantage of their new lightweight run and forget attitude and being scope-specific.
Godot 4 does not allow overriding build-in functions (neither did 3, but 4 is more specific about it). Overridden functions should be re-named and any calls to them also to make it clearer what the call is trying to do. Off the top of my head Pile.gd:add_child() but I know there are more

SPECIFIC

These may or may not address other listed items

pile.gd pre_sorted_order is never given a value
CardTemplate.gd:359 the logic is not neat (is not and is ! are not allowed in syntax). It can be fixed when 4.3 is released
test_facedown.gd:55 _previously_focused_cards does not seem to work in the test only. It works in other places (have not gotten to test demo yet).

OTHER

Github actions uses godot 3.4.4, so no builds will be able to pass until that is fixed
I'm not sure if breakpoints are carried over - if so, they should be deleted. They're to mark all of the code I touched
Lots of unused variables left over and their warnings.
Tweens are mostly handled correctly, but there are a few that don't work properly. Some are just added to the scene tree without tweeners (normally @onready var _tween = create_tween() not being in a function)
Documentation might need to be updated

There may be more things.

My intention is to keep working on it, but I wanted to share the "working" version for feedback and collaboration.

Made some edits based on experience of following this tutorial in v3.5.1 of Godot. I was able to complete the tutorial from start to finish, and end up with a working version of the sandbox with a deck containing the two custom cards that I could draw from.

Small change to say updated for 3.5.3 rather than 3.5.1 as originally stated.

Update QUICKSTART.md

not yet 100%. see pull request for details

fix from godot-tester issue 36

From: https://github.com/github/gitignore/blob/6eeebe6f49678aacd8311ce079842c971b3ebe96/Godot.gitignore Need to add the .godot folder since it's full of cooked assets. We also now include *.import files as recommended in the docs: https://docs.godotengine.org/en/4.3/tutorials/assets_pipeline/import_process.html#files-generated

Not using any custom settings. Just the defaults. I'm doing this on Godot 4.3. Not sure if that matters.

Fix a ton of gut errors: scene\resources\resource_format_text.cpp|453| res://addons/gut/gui/RunAtCursor.tscn:4 - ext_resource, invalid UID: uid://cr6tvdv0ve6cv - using text path instead: res://addons/gut/gui/play.png scene\resources\resource_format_text.cpp|453| res://addons/gut/gui/RunAtCursor.tscn:5 - ext_resource, invalid UID: uid://6wra5rxmfsrl - using text path instead: res://addons/gut/gui/arrow.png scene\resources\resource_format_text.cpp|453| res://addons/gut/gui/GutBottomPanel.tscn:6 - ext_resource, invalid UID: uid://cr6tvdv0ve6cv - using text path instead: res://addons/gut/gui/play.png scene\resources\resource_format_text.cpp|453| res://addons/gut/gui/GutBottomPanel.tscn:7 - ext_resource, invalid UID: uid://4gyyn12um08h - using text path instead: res://addons/gut/gui/RunResults.tscn || Cannot open file 'res://addons/gut/gui/RunResults.tscn'. || Failed loading resource: res://addons/gut/gui/RunResults.tscn. Make sure resources have been imported by opening the project in the editor at least once. res://addons/gut/gut_plugin.gd|8| Attempt to call function 'create_temp_directory' in base 'null instance' on a null instance. res://addons/gut/gut.gd|1| Parse Error: Could not resolve super class path "res://addons/gut/gut_to_move.gd". res://addons/gut/gui/BottomPanelShortcuts.gd|5| Invalid access to property or key 'editor_shortcuts_path' on a base object of type 'null instance'. res://addons/gut/gui/GutBottomPanel.gd|21| Invalid call. Nonexistent function 'get_rich_text_edit' in base 'MissingNode'. res://addons/gut/gui/GutBottomPanel.gd|52| Attempt to call function 'create_temp_directory' in base 'null instance' on a null instance. res://addons/gut/gui/GutBottomPanel.gd|317| Invalid access to property or key 'run_results' on a base object of type 'Nil'. res://addons/gut/gui/GutBottomPanel.gd|99| Invalid access to property or key 'shortcut_dialog' on a base object of type 'Nil'. Checked out gut tag v9.3.0 and replaced our addons/gut/ folder with their addons/gut/ folder. When running, gut tells us it's copying our config to use as a template, but I don't think we want to delete the template because all repo devs should use it: || GUT Info: Copying [res://.gut_editor_config.json] to [user://gut_temp_directory/gut_editor_config.json] || GUT Warning: File [res://.gut_editor_config.json] has been moved to [user://gut_temp_directory/gut_editor_config.json]. || You can delete res://.gut_editor_config.json || GUT Info: Copying [res://.gut_editor_shortcuts.cfg] to [user://gut_temp_directory/gut_editor_shortcuts.cfg] || GUT Warning: File [res://.gut_editor_shortcuts.cfg] has been moved to [user://gut_temp_directory/gut_editor_shortcuts.cfg]. || You can delete res://.gut_editor_shortcuts.cfg || GUT got some new images that are not imported yet. Please restart Godot. The Gut editor panel seems to work and I can run tests (they don't all pass).

Upgrade gut to v9.3.0, include `.import` files, update .gitignore

CardTemplate's _tween is a WeakRef and not a Tween. Also resets the project.godot to the compat renderer

db0 · 2025-06-23T17:58:48Z

Thanks for doing this. If you're still working on this, why not keep it as draft?

Removes awaiting tweens and provides a unique name for each popup

markp3rry and others added 19 commits February 18, 2024 12:01

Update QUICKSTART.md

03c70ac

Made some edits based on experience of following this tutorial in v3.5.1 of Godot. I was able to complete the tutorial from start to finish, and end up with a working version of the sandbox with a deck containing the two custom cards that I could draw from.

Update QUICKSTART.md

fec0c0a

Small change to say updated for 3.5.3 rather than 3.5.1 as originally stated.

Merge pull request db0#186 from markp3rry/patch-1

932414f

Update QUICKSTART.md

update to 4.0. all compile-time and most run-time errors solved.

b314af5

not yet 100%. see pull request for details

remerge update to quickstart.md

af1df15

Futher 3->4 fixes. Most tests can complete, even if they do not pass

a525aaa

Change github actions to 4.2.1 gut tester

8d2ae69

Create test_results.xml

0e535e7

output-file doesn't always work

b55ed70

fix from godot-tester issue 36

Update gut.yml

3dc7da0

Update gut.yml

a3d8f5f

change gut.yml to godot-gut-ci

0fd13ec

Update gut.yml

71e2535

Update gut.yml

6310632

Add *.import files

08ce068

Not using any custom settings. Just the defaults. I'm doing this on Godot 4.3. Not sure if that matters.

Merge pull request #3 from idbrii/gut-930

dcbc810

Upgrade gut to v9.3.0, include `.import` files, update .gitignore

Use get_ref before accessing card tweens (#4)

9287085

CardTemplate's _tween is a WeakRef and not a Tween. Also resets the project.godot to the compat renderer

menaechmi force-pushed the conversion branch from 6faf31a to 9287085 Compare June 23, 2025 17:32

menaechmi added 2 commits June 23, 2025 13:06

button.pressed -> button.button_pressed

a8ef3da

change uid of font

96a2ef9

menaechmi marked this pull request as draft June 23, 2025 18:30

menaechmi added 6 commits June 23, 2025 17:44

Fix card class unit tests

9b395b7

idle_frame is process_frame

a78810e

fix a few more if_tween()

ef0f554

remove AskInteger test

5353446

fix cardcontainer tests

0ae10ce

implement WeakRef tweens for CardContainers + Piles

0a96099

menaechmi added 11 commits June 23, 2025 23:34

cleanup some test teardown

832ee3f

remove await tweeners

945d8a8

Fix Pile Unit test

0b6de34

Removes awaiting tweens and provides a unique name for each popup

Fix pile tests

04e63ee

add _add_child, _move_child, _remove child

3d2b92c

fix card_class unit test

601abca

fix order of tests (got, expected) from (expected, got)

16d5df9

fix Deck_builder unit test

cd7335d

fix pile_class unit test

7114bea

fix cardcontainer unit test

9ee3734

re-enable a few tweens

426bf73

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Mostly complete conversion to 4.2.1 #188

Mostly complete conversion to 4.2.1 #188

menaechmi commented Mar 13, 2024 •

edited

Loading

Uh oh!

db0 commented Jun 23, 2025

Uh oh!

Uh oh!

Uh oh!

Mostly complete conversion to 4.2.1 #188

Are you sure you want to change the base?

Mostly complete conversion to 4.2.1 #188

Conversation

menaechmi commented Mar 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

GUT

DEMO / BASE SCENES

REWRITES

SPECIFIC

OTHER

Uh oh!

db0 commented Jun 23, 2025

Uh oh!

Uh oh!

menaechmi commented Mar 13, 2024 •

edited

Loading