-
Notifications
You must be signed in to change notification settings - Fork 10
refactor(selector): not hiding the first option
anymore
#4020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mfranzke
wants to merge
20
commits into
main
Choose a base branch
from
4019-dbselect-dropdown-checkmark-on-first-element
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
4eb469d
refactor: let's not hide the first element in the select anymore
mfranzke 37c89a2
Update packages/components/src/components/select/select.lite.tsx
mfranzke 392278d
test: updated snapshots
mfranzke 15ba5d5
test: updated snapshots
mfranzke 9b06c2e
refactor: removed those again
mfranzke 207d625
Merge branch 'main' into 4019-dbselect-dropdown-checkmark-on-first-el…
mfranzke 5c43e22
test: updated snapshots
mfranzke 417e830
Revert "test: updated snapshots"
mfranzke ca57f23
Merge branch 'main' into 4019-dbselect-dropdown-checkmark-on-first-el…
mfranzke 7e53415
Update DBSelect-should-have-same-aria-snapshot.yaml
mfranzke fbfa298
Update DBSelect-should-have-same-aria-snapshot.yaml
mfranzke 6e5effe
Update DBSelect-should-have-same-aria-snapshot.yaml
mfranzke 5fca738
Merge branch 'main' into 4019-dbselect-dropdown-checkmark-on-first-el…
mfranzke a4b5e47
test: updated snapshots
mfranzke 4069978
Merge branch 'main' into 4019-dbselect-dropdown-checkmark-on-first-el…
mfranzke 3b0056a
Merge branch 'main' into 4019-dbselect-dropdown-checkmark-on-first-el…
mfranzke fb0112b
Merge branch 'main' into 4019-dbselect-dropdown-checkmark-on-first-el…
mfranzke 424de71
Merge branch 'main' into 4019-dbselect-dropdown-checkmark-on-first-el…
mfranzke 33428fb
test: updated snapshot
mfranzke 4f40561
refactor: updated snapshots
mfranzke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.