Closed
Conversation
Contributor
|
E2E Report is ready. |
khamitovdr
reviewed
Feb 18, 2026
| TEMPORAL_AUTH_PRIVATE_KEY=$(openssl genpkey -algorithm RSA -pkeyopt "rsa_keygen_bits:4096" 2>/dev/null) | ||
| TEMPORAL_AUTH_PUBLIC_KEY=$(echo "${TEMPORAL_AUTH_PRIVATE_KEY}" | openssl rsa -pubout 2>/dev/null) | ||
| US_DYNAMIC_MASTER_TOKEN_PRIVATE_KEY=$(openssl genpkey -algorithm RSA -pkeyopt "rsa_keygen_bits:4096" 2>/dev/null) | ||
| UI_MASTER_TOKEN_PUBLIC_KEY_PRIMARY=$(echo "${TEMPORAL_AUTH_PRIVATE_KEY}" | openssl rsa -pubout 2>/dev/null) |
There was a problem hiding this comment.
Suggested change
| UI_MASTER_TOKEN_PUBLIC_KEY_PRIMARY=$(echo "${TEMPORAL_AUTH_PRIVATE_KEY}" | openssl rsa -pubout 2>/dev/null) | |
| UI_MASTER_TOKEN_PUBLIC_KEY_PRIMARY=$(echo "${US_DYNAMIC_MASTER_TOKEN_PRIVATE_KEY}" | openssl rsa -pubout 2>/dev/null) |
khamitovdr
requested changes
Feb 18, 2026
khamitovdr
left a comment
khamitovdr
left a comment
There was a problem hiding this comment.
It seems we should generate US_DYNAMIC_MASTER_TOKEN_PRIVATE_KEY here too
Line 537 in 0f09348
khamitovdr
requested changes
Feb 18, 2026
There was a problem hiding this comment.
May be consider pattern <service_alias>_DYNAMIC_US_AUTH_<PRIVATE/PUBLIC>_KEY(?_SECONDARY)?
Now the problem is that US_DYNAMIC_MASTER_TOKEN_PRIVATE_KEY already exists, but this is the key related to UI. There are no good name to choose for BI public key.
Moreover it is tricky to understand that UI_MASTER_TOKEN_PUBLIC_KEY_PRIMARY and US_DYNAMIC_MASTER_TOKEN_PRIVATE_KEY are pair by name.
Author
|
Closing in favor #405 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.