Prevent double quoting in db_signals filtering #1517
+51
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor db_signals() to filter on string names before converting to Column objects, preventing double quoting when filtering by name. Previously, filtering was applied after Column object creation, causing incorrect name matching. Add test cases to verify column names with special characters (uppercase, underscores) are handled correctly in mutate operations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could fix #1434
The bottom line of the issue was that when having a column name of the sort
xY, doingstrover that around here returned the doubled quote version'"xY"'(presumably because column names are lowercased by default) rendering the output list ofdb_signalto be emptyI have refactored a bit the method to just convert to columns if required so as to avoid doing
stroverColumnobjects.