-
Notifications
You must be signed in to change notification settings - Fork 76
✨ DQX App Skeleton #982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
✨ DQX App Skeleton #982
Conversation
|
❌ 395/502 passed, 42 flaky, 107 failed, 49 skipped, 2h2m24s total ❌ test_save_dataframe_as_table: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (593ms)❌ test_save_streaming_dataframe_in_table: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (710ms)❌ test_save_batch_dataframe_to_path: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (617ms)❌ test_save_streaming_dataframe_to_path: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (635ms)❌ test_get_reference_dataframes: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (696ms)❌ test_load_checks_from_volume_file_missing: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (735ms)❌ test_e2e_workflow: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (13.139s)❌ test_load_checks_from_volume_file_missing_in_dir_path: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (633ms)❌ test_load_checks_from_missing_volume: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (654ms)❌ test_save_and_load_checks_from_volume: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (583ms)❌ test_load_checks_from_volume_in_installation_when_checks_file_does_not_exist: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (2.329s)❌ test_e2e_workflow_for_patterns_exclude_patterns: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (13.075s)❌ test_save_load_checks_from_volume_in_user_installation: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (1.734s)❌ test_e2e_workflow_for_patterns_exclude_output: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (13.731s)❌ test_read_input_data_no_input_format: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (598ms)❌ test_e2e_workflow_for_patterns_table_checks_storage: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (12.461s)❌ test_profile_tables_include_patterns: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (707ms)❌ test_profile_tables_no_pattern_match: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (611ms)❌ test_profile_tables_for_patterns_with_no_options: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (561ms)❌ test_profile_tables_for_patterns_with_no_matched_options: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (641ms)❌ test_profile_tables_for_patterns_with_common_opts: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (595ms)❌ test_profile_tables_for_patterns_with_different_opts: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (680ms)❌ test_profile_tables_for_patterns_with_partial_opts_match: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (653ms)❌ test_profile_tables_for_patterns_with_selected_columns: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (740ms)❌ test_apply_checks_failed: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (672ms)❌ test_profile_table: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (670ms)❌ test_profile_table_non_TEST_SCHEMA_opts: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (656ms)❌ test_profile_table_with_column_selection: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (606ms)❌ test_profile_tables_for_patterns: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (714ms)❌ test_profile_tables_for_patterns_with_exclude_patterns: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (653ms)❌ test_profiler_workflow_class: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (12.35s)❌ test_profiler_workflow_for_multiple_run_configs: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (12.77s)❌ test_profile_table_with_pk_detection: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (617ms)❌ test_quality_checker_workflow: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (13.587s)❌ test_profile_tables_for_patterns_with_pk_detection: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (623ms)❌ test_profiler_workflow: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (12.523s)❌ test_profiler_workflow_for_patterns: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (12.465s)❌ test_quality_checker_workflow_for_multiple_run_configs: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (12.807s)❌ test_profiler_workflow_with_custom_install_folder: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (12.059s)❌ test_profiler_workflow_for_patterns_with_exclude_patterns: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (11.871s)❌ test_quality_checker_workflow_for_multiple_run_configs_table_checks_storage: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (12.508s)❌ test_profiler_workflow_for_patterns_exclude_output: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (12.119s)❌ test_quality_checker_workflow_for_patterns: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (12.702s)❌ test_quality_checker_workflow_table_checks_storage: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (12.354s)❌ test_quality_checker_workflow_with_metrics: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (12.885s)❌ test_profiler_workflow_for_patterns_table_checks_storage: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (12.133s)❌ test_quality_checker_workflow_for_patterns_exclude_patterns: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (12.422s)❌ test_quality_checker_workflow_with_custom_install_folder: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (12.21s)❌ test_quality_checker_workflow_with_quarantine_and_metrics: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (13.756s)❌ test_profiler_workflow_filter_out_all_data: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (12.312s)❌ test_quality_checker_workflow_for_patterns_exclude_output: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (12.557s)❌ test_profiler_detect_pk_from_table_with_llm: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (697ms)❌ test_profiler_detect_pk_from_path_with_llm: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (707ms)❌ test_e2e_workflow_with_metrics: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (13.191s)❌ test_quality_checker_workflow_with_quarantine_and_metrics_for_patterns: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (13.356s)❌ test_quality_checker_workflow_for_patterns_table_checks_storage: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (13.031s)❌ test_custom_metrics_in_workflow_for_all_run_configs: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (13.709s)❌ test_load_checks_with_special_characters_in_table_name: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (678ms)❌ test_save_and_load_checks_from_table: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (630ms)❌ test_save_checks_to_table_with_unresolved_for_each_column: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (642ms)❌ test_load_checks_from_table_saved_from_dict_with_unresolved_for_each_column: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (705ms)❌ test_load_checks_from_table_with_unresolved_for_each_column: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (656ms)❌ test_save_and_load_checks_from_table_with_run_config: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (649ms)❌ test_save_and_load_checks_to_table_output_modes: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (721ms)❌ test_save_load_checks_from_table_in_user_installation: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (1.582s)❌ test_profiler_workflow_save_to_lakebase: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (12.169s)❌ test_load_checks_when_checks_table_does_not_exist: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (647ms)❌ test_quality_checker_workflow_with_streaming_quarantine_and_metrics: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (13.164s)❌ test_save_results_in_table: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (648ms)❌ test_quality_checker_workflow_with_continuous_streaming_quarantine_and_metrics: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (12.836s)❌ test_save_results_in_table_only_output: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (724ms)❌ test_save_results_in_table_only_quarantine: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (689ms)❌ test_save_results_in_table_in_user_installation: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (1.682s)❌ test_save_results_in_table_in_user_installation_only_output: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (1.621s)❌ test_save_results_in_table_in_user_installation_only_quarantine: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (1.562s)❌ test_save_results_in_table_in_user_installation_output_table_provided: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (1.489s)❌ test_save_results_in_table_in_user_installation_quarantine_table_provided: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (1.538s)❌ test_save_results_in_table_in_user_installation_missing_output_and_quarantine_table: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (1.555s)❌ test_save_streaming_results_in_table: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (739ms)❌ test_save_results_in_table_in_custom_folder_installation: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (1.448s)❌ test_engine_without_observer_no_metrics_saved[apply_checks_and_save_in_table]: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (573ms)❌ test_apply_checks_by_metadata_and_save_in_table_raises_error_for_sparkconnect[apply_checks_by_metadata_and_save_in_table]: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (680ms)❌ test_engine_without_observer_no_metrics_saved[apply_checks_by_metadata_and_save_in_table]: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (690ms)❌ test_save_results_in_table_raises_error_for_sparkconnect: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (712ms)❌ test_apply_checks_by_metadata_and_save_in_table_raises_error_for_sparkconnect[apply_checks_and_save_in_table]: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (780ms)❌ test_get_tables_and_paths_from_file_delta_dataframe: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (700ms)❌ test_get_tables_and_paths_from_file_parquet_dataframe: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (721ms)❌ test_get_tables_and_paths_from_joined_tables_dataframe: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (722ms)❌ test_get_tables_and_paths_from_table_dataframe: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (700ms)❌ test_get_tables_and_paths_from_aggregated_table_dataframe: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (630ms)❌ test_get_tables_and_paths_from_unioned_tables_dataframe: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (621ms)❌ test_get_tables_and_paths_from_mixed_dataframe: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (685ms)❌ test_get_tables_and_paths_from_streaming_table_based_dataframe: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (661ms)❌ test_list_tables_with_exclude_patterns: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (631ms)❌ test_end_to_end_installation_and_workflow_with_upload_dependencies: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'main'. (568ms)❌ test_list_tables: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (639ms)❌ test_profile_with_custom_folder: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (11.685s)❌ test_load_checks_from_volume_as_yaml_file: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (618ms)❌ test_load_checks_from_volume_as_json_file: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (629ms)❌ test_load_invalid_checks_from_volume_as_yaml_file: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (744ms)❌ test_load_invalid_checks_from_volume_as_json_file: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (662ms)❌ test_apply_checks_with_custom_folder: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (12.428s)❌ test_save_checks_in_volume_file_as_yml: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (1.562s)❌ test_save_checks_in_volume_file_as_json: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (1.717s)❌ test_save_and_load_checks_from_volume_with_filters: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (710ms)❌ test_e2e_with_custom_folder: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (17.997s)❌ test_compare_datasets_check_missing_records_with_partial_filter: databricks.sdk.errors.platform.BadRequest: PERMISSION_DENIED: User does not have CREATE SCHEMA on Catalog 'dqx'. (1.079s)Flaky tests:
Running from acceptance #3565 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR introduces a basic web application structure for the DQX framework. It sets up a full-stack application with a FastAPI backend and a React-based frontend using modern tooling including Vite, TanStack Router, and Tailwind CSS.
Key changes:
- Complete application scaffold with backend API and frontend UI
- Configuration management for DQX workspace settings and run configurations
- User interface with routing, theming, and component library
Reviewed changes
Copilot reviewed 62 out of 66 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| app/vite.config.ts | Vite configuration with dynamic port resolution and routing setup |
| app/tsconfig.json | TypeScript compiler configuration for the React application |
| app/package.json | Frontend dependencies and build scripts |
| app/pyproject.toml | Python package configuration with FastAPI backend dependencies |
| app/src/databricks_labs_dqx_app/backend/*.py | Backend API implementation with routes, models, and utilities |
| app/src/databricks_labs_dqx_app/ui/routes/*.tsx | Frontend route components for configuration and runs management |
| app/src/databricks_labs_dqx_app/ui/components/**/*.tsx | Reusable UI components including theme provider and layouts |
| app/README.md | Documentation for development and deployment workflows |
Comments suppressed due to low confidence (1)
app/src/databricks_labs_dqx_app/ui/routes/_sidebar/runs.tsx:1
- The comment mentions 'Input and Output config' but the more accurate technical terms based on the codebase context would be 'input_config and output_config' to match the actual field names in RunConfig.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if not path_str.endswith(".yml") and not path_str.endswith(".yaml"): | ||
| raise ValueError("Configuration path must be a valid .yml or .yaml file") |
Copilot
AI
Jan 6, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error message incorrectly states the requirement. According to line 58, the validation checks if the path does NOT end with .yml or .yaml, meaning it should be a path TO a yml/yaml file. However, the function is named save_settings and takes InstallationSettings which has an install_folder field, suggesting it should be a folder path. The error message and validation logic are inconsistent with the field name and broader context where folders are normalized to include config.yml (lines 66-67).
| if not path_str.endswith(".yml") and not path_str.endswith(".yaml"): | |
| raise ValueError("Configuration path must be a valid .yml or .yaml file") | |
| if path_str.endswith(".yml") or path_str.endswith(".yaml"): | |
| raise ValueError("Installation folder must be a folder path, not a .yml or .yaml file") |
| db: DatabaseConfig = _Unset | ||
|
|
||
| @property |
Copilot
AI
Jan 6, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The field 'db' is ambiguous. Consider renaming to 'database' or 'database_config' for clarity, especially since DatabaseConfig is already descriptive.
| db: DatabaseConfig = _Unset | |
| @property | |
| database: DatabaseConfig = Field(default=_Unset, alias="db") | |
| @property | |
| def db(self) -> DatabaseConfig: | |
| """ | |
| Backwards-compatible alias for the `database` configuration. | |
| """ | |
| return self.database | |
| @property |
| # Accessing protected member _checks_handler_factory as it seems to be the way to get the storage config | ||
| # properly constructed from the RunConfig | ||
| try: | ||
| _, storage_config = engine._checks_handler_factory.create_for_run_config(run_config) |
Copilot
AI
Jan 6, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accessing protected member '_checks_handler_factory' violates encapsulation. Consider adding a public method to DQEngine for retrieving storage config from a run config, or documenting why direct access is necessary.
|
All commits in PR should be signed ('git commit -S ...'). See https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits |
b3dce71 to
076e845
Compare
076e845 to
6c1a831
Compare
This PR introduces a basic version of the app in a separate subfolder of the project.