remove unneeded log_softmax() call #795
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When generating clothing or background category labels, the log_softmax() call is immediately followed by an argmax() call. In this situation, the log_softmax() is not needed. Since log_softmax is monotonically increasing, the max value before log_softmax will still be the max value after log_softmax, so we can go to argmax() directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating clothing or background category labels, the log_softmax() call is immediately followed by an argmax() call. In this situation, the log_softmax() is not needed.
Since log_softmax is monotonically increasing, the max value before log_softmax will still be the max value after log_softmax, so we can go to argmax() directly.