Skip to content

test: extend linting to customized test-project eslint config files #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

MikeMcC399
Copy link
Collaborator

Situation

eslint.config.mjs uses { ignores: ['test-project/'] } since most files are directly scaffolded from Cypress, however this means that customized files are also not linted.

There are currently some minor formatting differences in example ESLint config files in test-project/eslint-configs compared to how they are shown in the README document.

Change

Extend linting to include:

Make changes using npx eslint --fix.

Manually change test-project/eslint-configs/eslint.globals.mjs to conform to change made by Prettier to embedded JavaScript in Markdown in README > Cypress globals section.

Verification

npm run lint

and confirm that there are no errors reported.

@cypress-app-bot
Copy link

@MikeMcC399 MikeMcC399 marked this pull request as ready for review June 6, 2025 08:04
@jennifer-shehane jennifer-shehane merged commit 22b6122 into cypress-io:master Jun 6, 2025
12 checks passed
@MikeMcC399 MikeMcC399 deleted the test-project-config-linting branch June 6, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants