breaking: remove built-ins from @cypress/webpack-batteries-included-preprocessor
#31738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtofStryker
changed the title
@cypress/webpack-batteries-included-preprocessor
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
breaking/remove_built_ins_from_webpack_5
|
| Run status |
|
| Run duration | 18m 46s |
| Commit |
|
| Committer | Bill Glesias |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
8
|
Pending
|
1064
|
Skipped
|
0
|
Passing
|
23193
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
0%
|
|
|---|---|
|
Untested elements
|
4
|
|
Tested elements
|
0
|
Accessibility
97.09%
|
|
|---|---|
|
Failed rules
|
0 critical
1 serious
0 moderate
0 minor
|
|
Failed elements
|
4
|
AtofStryker
force-pushed
the
breaking/remove_built_ins_from_webpack_5
branch
3 times, most recently
from
9066b10 to
7a6c78c
Compare
…rade as they should no longer be needed for most users
AtofStryker
force-pushed
the
breaking/remove_built_ins_from_webpack_5
branch
from
7a6c78c to
2ca3df4
Compare
AtofStryker
commented
May 21, 2025
| @@ -40,7 +40,7 @@ describe('devServer', function () { | |||
| // Writing to disk includes the correct source map size, where the difference will be made up from stat size vs parsed size | |||
| // This is critical if a user is trying to debug to determine if they have large source maps or other large files in their dev-server under test | |||
| describe('writes to disk if DEBUG=cypress-verbose:webpack-dev-server:bundle-analyzer is set', async () => { | |||
| const WEBPACK_DEV_SERVER_VERSIONS: (4 | 5)[] = [4, 5] | |||
| const WEBPACK_DEV_SERVER_VERSIONS: (5)[] = [5] | |||
There was a problem hiding this comment.
I think we have a bad merge into the 15 branch. This is very likely failing
jennifer-shehane
approved these changes
May 27, 2025
Co-authored-by: Jennifer Shehane <[email protected]>
Co-authored-by: Jennifer Shehane <[email protected]>
jennifer-shehane
approved these changes
May 28, 2025
mschile
reviewed
May 28, 2025
| @@ -146,42 +127,42 @@ const getDefaultWebpackOptions = () => { | |||
| resolve: { | |||
| extensions: ['.js', '.json', '.jsx', '.mjs', '.coffee'], | |||
| fallback: { | |||
There was a problem hiding this comment.
Do we need to set everything to false or can we just not provide the fallback config?
There was a problem hiding this comment.
Honestly it isn't entirely clear 😂 . The recommendation AFAIK is to set the fallback to false. What I have noticed, though it isn't documented, is the polyfills sometimes make their way in when you don't specify a config and they just happen to exist in your node_modules directory. But that might be a side effect of something else
mschile
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
With the release of Cypress 15, we are removing the default built-ins from the
@cypress/webpack-batteries-included-preprocessoras they are usually not used by end users within their cypress tests and bloat the user bundle. This is also to reduce security vulnerabilities introduced by the built-ins.Note: some tests needed to be pulled out into their own directory to prevent cross-pollination of the build-ins in the cypress config. Hence why the screenshots test and the node built in test were both moved
Steps to test
If wanting to use the built-ins, set up a project that has references to
pathwithin your spec file. notice the test fails because path is no longer provided by the preprocessorHow has the user experience changed?
PR Tasks
cypress-documentation? chore: add migration guide for@cypress/webpack-batteries-included-preprocessorbuilt-ins removal cypress-documentation#6192type definitions?