Streamline #includes

[MichaelChirico]

As flagged by clang-tidy:

https://clang.llvm.org/extra/clang-tidy/checks/misc/include-cleaner.html

Usually I ignore these recommendations for R packages, but the C code here is self-contained enough that the change is easier to motivate.

[aviator-app]

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR is not ready to merge (currently in state blocked): PR cannot be automatically rebased, please rebase manually to continue.

Once the issues are resolved, remove the blocked label and re-queue the pull request. Note that the pull request will be automatically re-queued if it has the mergequeue label.

Pending Status Checks

• ✅ 18 tests passing!

---

See the real-time status of this PR on the Aviator webapp.

Use the Aviator Chrome Extension to see the status of your PR within GitHub.

[moodymudskipper]

Thanks!

[aviator-app]

This pull request failed to merge: some required checks failed. After you have resolved the problem, you should remove the blocked pull request label from this PR and then try to re-queue the PR. Note that the pull request will be automatically re-queued if it has the mergequeue label.

Failed checks: rcc, Smoke test: stock R

[moodymudskipper]

Oops, this still fails @MichaelChirico :

using C compiler: ‘gcc (Ubuntu 13.3.0-6ubuntu2~24.04) 13.3.0’
ccache gcc -I"/opt/R/4.4.3/lib/R/include" -DNDEBUG -I/usr/local/include -fpic -g -O2 -c constructive.c -o constructive.o
constructive.c:6:10: fatal error: R_ext/error.h: No such file or directory

[MichaelChirico]

Ah, true, it's Error.h.

[moodymudskipper]

It seems like I need inttypes.h for SCNxPTR

[MichaelChirico]

It seems like I need inttypes.h for SCNxPTR

indeed. shows me for obeying the lint warning blindly 😉

I filed a bug about the incorrect finding...

[aviator-app]

This pull request failed to merge: PR cannot be automatically rebased, please rebase manually to continue. After you have resolved the problem, you should remove the blocked pull request label from this PR and then try to re-queue the PR. Note that the pull request will be automatically re-queued if it has the mergequeue label.

Additional debug info: Failed to rebase this PR onto the latest changes from the base branch. You will probably need to rebase this PR manually and resolve conflicts).

[aviator-app]

Free usage limit reached: 15 users this month.To add more users, upgrade to the Pro plan.

[aviator-app]

Free usage limit reached: 15 users this month.To add more users, upgrade to the Pro plan.

[moodymudskipper]

This covr error with Ubunto on R 4.5 is very weird, and the other errors confuse me as well, I might just restart this from scratch with baby steps to see what breaks

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.95%. Comparing base (a110376) to head (59d1195).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #537   +/-   ##
=======================================
  Coverage   83.95%   83.95%           
=======================================
  Files         121      121           
  Lines        4617     4617           
=======================================
  Hits         3876     3876           
  Misses        741      741           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[aviator-app]

Free usage limit reached: 15 users this month.To add more users, upgrade to the Pro plan.