Handle NumberFormatException in UserInfoCacheServiceImpl.onlineUser()#185
Merged
crossoverJie merged 3 commits intofeature/add-checkstyle-code-stylefrom Feb 5, 2026
Merged
Conversation
2 tasks
…ser() Co-authored-by: crossoverJie <15684156+crossoverJie@users.noreply.github.com>
Co-authored-by: crossoverJie <15684156+crossoverJie@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Refactor to apply review feedback on Checkstyle PR
Handle NumberFormatException in UserInfoCacheServiceImpl.onlineUser()
Feb 5, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/add-checkstyle-code-style #185 +/- ##
=======================================================================
- Coverage 50.37% 50.37% -0.01%
- Complexity 317 318 +1
=======================================================================
Files 79 79
Lines 1725 1729 +4
Branches 133 133
=======================================================================
+ Hits 869 871 +2
- Misses 816 818 +2
Partials 40 40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3ae257b
into
feature/add-checkstyle-code-style
3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
onlineUser()method crashes when Redis contains non-numeric user IDs due to uncaughtNumberFormatExceptionfromLong.valueOf().Changes
Long.valueOf(member)to handle invalid formats@Slf4jfor logging invalid entries with warning messageThis ensures the online user list remains available even if Redis data becomes corrupted or invalid data is manually inserted.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.