feat!: Fix heading ID discrepancy between sidebar and article#19
Merged
valeriansaliou merged 1 commit intocrisp-oss:masterfrom Feb 2, 2026
Merged
Conversation
This fixes incorrect IDs in the sidebar when a heading contains an underscore (`_`). For example, “## branding.api_app_name” gets rendered as ```html <h2 id="brandingapiappname"><a class="title-anchor" href="#brandingapiappname">branding.api_app_name</a></h2> ``` in the page, but was rendered as ```html <a href="#brandingapi_app_name" data-anchor="#brandingapi_app_name" class="nest-navigate-link" data-cshid="98e0cf7f-7cea-a908-2452-f43b1fa1729c"><span class="nest-navigate-link-text">branding.api_app_name</span></a> ``` in the sidebar. This meant the sidebar was broken, because it pointed to an inexistent ID.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes incorrect IDs in the sidebar when a heading contains an underscore (
_).For example, “## branding.api_app_name” gets rendered as
in the page, but was rendered as
in the sidebar.
This meant the sidebar was broken, because it pointed to an inexistent ID.