-
Notifications
You must be signed in to change notification settings - Fork 866
Add Bryston protocol #2203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ggiraudon
wants to merge
2
commits into
crankyoldgit:master
Choose a base branch
from
ggiraudon:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add Bryston protocol #2203
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,72 @@ | ||
// Copyright 2025 Guillaume Giraudon - Colquhoun Audio Laboratories | ||
|
||
|
||
/// @file | ||
/// @brief Support for Bryston Protocols. | ||
/// @note Currently only tested BP19/BR20 but should work for all Bryston Products. | ||
|
||
|
||
// Supports: | ||
// Brand: Bryston | ||
|
||
#include <algorithm> | ||
#include "IRrecv.h" | ||
#include "IRsend.h" | ||
#include "IRutils.h" | ||
|
||
|
||
// Constants | ||
const uint16_t kBrystonTicks = 315; // Number of bits in a Bryston message. | ||
const uint16_t kBrystonHdrMark = 0; | ||
const uint16_t kBrystonHdrSpace = 0; | ||
const uint16_t kBrystonOneMark = 6 * kBrystonTicks; | ||
const uint16_t kBrystonOneSpace = 1 * kBrystonTicks; | ||
const uint16_t kBrystonZeroMark = 1 * kBrystonTicks; | ||
const uint16_t kBrystonZeroSpace = 6 * kBrystonTicks; | ||
const uint16_t kBrystonMinGap = 0; | ||
const uint16_t kBrystonFooterMark = 0; | ||
|
||
#if SEND_BRYSTON | ||
/// Send a Bryston formatted message. | ||
/// @param[in] data The message to be sent. | ||
/// @param[in] nbits The number of bits of message to be sent. | ||
/// @param[in] repeat The number of times the command is to be repeated. | ||
void IRsend::sendBryston(uint64_t data, uint16_t nbits, uint16_t repeat) { | ||
Serial.printf("Sending Bryston: %016llX\n", data); | ||
|
||
sendGeneric(kBrystonHdrMark, kBrystonHdrSpace, kBrystonOneMark, kBrystonOneSpace, | ||
kBrystonZeroMark, kBrystonZeroSpace, kBrystonFooterMark, kBrystonMinGap, data, | ||
nbits, 38, true, repeat, 33); | ||
} | ||
#endif // SEND_Bryston | ||
|
||
#if DECODE_BRYSTON | ||
/// Decode the supplied Bryston message. | ||
/// @param[in,out] results Ptr to the data to decode & where to store the result | ||
/// @param[in] offset The starting index to use when attempting to decode the | ||
/// raw data. Typically/Defaults to kStartOffset. | ||
/// @param[in] nbits The number of data bits to expect. | ||
/// @param[in] strict Flag indicating if we should perform strict matching. | ||
bool IRrecv::decodeBryston(decode_results *results, uint16_t offset, | ||
const uint16_t nbits, const bool strict) { | ||
if (strict && nbits != kBrystonBits) | ||
return false; // We expect Bryston to be a certain sized message. | ||
|
||
uint64_t data = 0; | ||
|
||
// Match Header + Data + Footer | ||
if (!matchGeneric(results->rawbuf + offset, &data, | ||
results->rawlen - offset, nbits, | ||
kBrystonHdrMark, kBrystonHdrSpace, | ||
kBrystonOneMark, kBrystonOneSpace, | ||
kBrystonZeroMark, kBrystonZeroSpace, | ||
kBrystonFooterMark, kBrystonMinGap, true)) return false; | ||
// Success | ||
results->bits = nbits; | ||
results->value = data; | ||
results->decode_type = decode_type_t::BRYSTON; | ||
results->command = 0; | ||
results->address = 0; | ||
return true; | ||
} | ||
#endif // DECODE_Bryston |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably a leftover from debug during development that was forgotten to be removed?