Add protocol Delonghi N* to library #2195
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I can't pin-point the faults in the pull request. Please advise. |
crankyoldgit
requested changes
Dec 18, 2025
Owner
crankyoldgit
left a comment
crankyoldgit
left a comment
There was a problem hiding this comment.
In principle, this looks fine to me. It just needs to be re-based and pass the tests and we can merge it.
Appologies for the wait in reviewing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested both sending and receiving for the Delonghi N82 airco
All features work.
The remote is name- and numberless. A generic remote lists the other devices listed in the .h file.
The decoding routine moved before NEC_LIKE to avoid grabbing the data before NEC_LIKE does.