-
Notifications
You must be signed in to change notification settings - Fork 4.1k
fix: contributing.mdx file #9665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 2 files
|
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 37 files (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="extensions/vscode/src/diff/vertical/handler.ts">
<violation number="1" location="extensions/vscode/src/diff/vertical/handler.ts:377">
P2: Undo-stop options are ignored—options object is not passed to `editor.edit`, so undo stops aren’t disabled.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| await this.editor.edit((editBuilder) => { | ||
| editBuilder.replace(this.range, replaceContent), | ||
| { undoStopAfter: false, undoStopBefore: false }; | ||
| (editBuilder.replace(this.range, replaceContent), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2: Undo-stop options are ignored—options object is not passed to editor.edit, so undo stops aren’t disabled.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At extensions/vscode/src/diff/vertical/handler.ts, line 377:
<comment>Undo-stop options are ignored—options object is not passed to `editor.edit`, so undo stops aren’t disabled.</comment>
<file context>
@@ -374,8 +374,8 @@ export class VerticalDiffHandler implements vscode.Disposable {
await this.editor.edit((editBuilder) => {
- editBuilder.replace(this.range, replaceContent),
- { undoStopAfter: false, undoStopBefore: false };
+ (editBuilder.replace(this.range, replaceContent),
+ { undoStopAfter: false, undoStopBefore: false });
});
</file context>
RomneyDa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sarthakNITT looks like there's a large diff here and the described changes to contributing.mdx are just a couple lines, also it's to contributing.md I'm gonna close this to be safe, could you open another PR with the proposed changes if needed?
Description
npm run startwithnpm run devto correctly run Mintlify docs locally (mintlify dev) on http://localhost:3000.Checklist
Continue Tasks
Powered by Continue
Summary by cubic
Use npm run dev instead of npm run start to run Mintlify docs locally at http://localhost:3000. Also cleans up formatting and stabilizes a few CLI/UI tests; no functional changes.
Written for commit 32a1335. Summary will update on new commits.