Add ulimits to `podman update` #26445

aaron-ang · 2025-06-17T04:38:39Z

Does this PR introduce a user-facing change?

Added `--ulimit` flag to `podman update` allowing users to edit container ulimits.

packit-as-a-service · 2025-06-17T04:43:55Z

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

packit-as-a-service · 2025-06-17T04:43:55Z

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

packit-as-a-service · 2025-06-17T04:43:55Z

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

Honny1 · 2025-06-17T08:43:55Z

Hi, I did a quick code check. And you need to move this definition of the ulimit flag to this if statement.

Luap99 · 2025-06-17T12:02:54Z

The commit needs a sign off, see https://github.com/containers/podman/blob/main/CONTRIBUTING.md#sign-your-prs

Also please add the Fixes: #xxx line to your commit message as well.

test/system/280-update.bats

test/e2e/update_test.go

aaron-ang · 2025-06-18T06:46:52Z

What is the merge workflow for this project? Should I always squash my commits into a single commit?

Luap99

Does this work correctly with --ulimit host on update? AFAICT it should unset all limts from the spec but the parser sets it to nil which means the update code considers it unset? I think the code likely needs to pass an explicit empty slice in that case?

test/system/280-update.bats

docs/source/markdown/podman-update.1.md.in

Luap99 · 2025-06-18T09:27:33Z

What is the merge workflow for this project? Should I always squash my commits into a single commit?

For a small feature like this yes. In general commits must be logical units and we prefer code, test and docs to be part of the same commit. However if you do some slight refactoring or fix multiple things than they should be in separate commits.

test/system/280-update.bats

test/apiv2/20-containers.at

libpod/container_internal.go

test/system/280-update.bats

Honny1

The linter is failing. Please rebase to main to ensure the recent linter updates are applied to your changes.

pkg/util/rlimit.go

aaron-ang · 2025-11-19T21:24:21Z

@Honny1 seems like the failures are unrelated?

Honny1 · 2025-11-20T10:27:23Z

Yes, it looks like that. I reran the tests.

Honny1 · 2025-11-20T13:10:19Z

pkg/api/handlers/libpod/containers.go


 	if err := decoder.Decode(&query, r.URL.Query()); err != nil {
-		utils.Error(w, http.StatusBadRequest, fmt.Errorf("failed to parse parameters for %s: %w", r.URL.String(), err))
+		utils.BadRequest(w, "restartPolicy", query.RestartPolicy, err)


I’m not sure about this. At first glance it makes sense, but looking deeper, I am not sure about the query.RestartPolicy value. Will it be an empty string when parsing fails, or something else?

good point, I've reverted the changes.

pkg/util/rlimit.go

Signed-off-by: Aaron Ang <[email protected]>

Honny1

LGTM,

I'm not sure why this PR ended up with the governance and machine labels.

cc @Luap99, @baude for final review and merge.

openshift-ci · 2025-11-24T12:04:01Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aaron-ang, Honny1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [Honny1]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

aaron-ang · 2025-12-16T00:16:03Z

hi @Luap99 @baude could you please take a look?

openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note labels Jun 17, 2025

github-actions bot added the kind/api-change Change to remote API; merits scrutiny label Jun 17, 2025

aaron-ang force-pushed the update-ulimit branch from 8d59487 to 096cd17 Compare June 17, 2025 04:43

aaron-ang force-pushed the update-ulimit branch from 096cd17 to 3c736e7 Compare June 17, 2025 04:51

Luap99 reviewed Jun 17, 2025

View reviewed changes

test/system/280-update.bats Outdated Show resolved Hide resolved

baude reviewed Jun 17, 2025

View reviewed changes

test/e2e/update_test.go Outdated Show resolved Hide resolved

baude reviewed Jun 17, 2025

View reviewed changes

test/e2e/update_test.go Outdated Show resolved Hide resolved

aaron-ang force-pushed the update-ulimit branch 2 times, most recently from 22d4ec1 to 81fe400 Compare June 17, 2025 18:20

aaron-ang marked this pull request as ready for review June 17, 2025 18:23

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 17, 2025

aaron-ang force-pushed the update-ulimit branch from 81fe400 to 8fbe7b8 Compare June 17, 2025 18:25

aaron-ang force-pushed the update-ulimit branch from 0969d43 to 34c284d Compare June 18, 2025 06:56

Luap99 reviewed Jun 18, 2025

View reviewed changes

test/system/280-update.bats Show resolved Hide resolved

test/system/280-update.bats Outdated Show resolved Hide resolved

test/system/280-update.bats Outdated Show resolved Hide resolved

docs/source/markdown/podman-update.1.md.in Show resolved Hide resolved

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 25, 2025

aaron-ang force-pushed the update-ulimit branch 2 times, most recently from e03b8f4 to 32aa965 Compare July 6, 2025 03:22

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 6, 2025

aaron-ang marked this pull request as draft July 6, 2025 03:23

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 6, 2025

danishprakash reviewed Jul 14, 2025

View reviewed changes

test/system/280-update.bats Show resolved Hide resolved

aaron-ang force-pushed the update-ulimit branch from 32aa965 to beda41d Compare October 13, 2025 22:59

aaron-ang force-pushed the update-ulimit branch from ccc007e to 512efe2 Compare October 15, 2025 21:57

Honny1 reviewed Oct 16, 2025

View reviewed changes

test/apiv2/20-containers.at Outdated Show resolved Hide resolved

aaron-ang force-pushed the update-ulimit branch 4 times, most recently from 4daaf4b to cf33218 Compare November 16, 2025 06:27

aaron-ang requested a review from Honny1 November 16, 2025 07:19

Honny1 requested changes Nov 18, 2025

View reviewed changes

libpod/container_internal.go Outdated Show resolved Hide resolved

test/system/280-update.bats Show resolved Hide resolved

aaron-ang force-pushed the update-ulimit branch 3 times, most recently from 63f34be to 6735519 Compare November 19, 2025 03:44

Honny1 reviewed Nov 19, 2025

View reviewed changes

pkg/util/rlimit.go Show resolved Hide resolved

aaron-ang force-pushed the update-ulimit branch 5 times, most recently from b8c16a5 to e016879 Compare November 19, 2025 18:46

Honny1 reviewed Nov 20, 2025

View reviewed changes

aaron-ang added 2 commits November 20, 2025 22:59

Add ulimits to podman update API

e0fc51e

Signed-off-by: Aaron Ang <[email protected]>

Clamp rootless rlimits to host on format

a9dd858

Signed-off-by: Aaron Ang <[email protected]>

aaron-ang force-pushed the update-ulimit branch from e016879 to a9dd858 Compare November 21, 2025 07:00

aaron-ang requested a review from Honny1 November 21, 2025 23:38

Honny1 approved these changes Nov 24, 2025

View reviewed changes

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2025

aaron-ang requested review from Luap99 and baude December 1, 2025 20:21

Add ulimits to podman update #26445

Are you sure you want to change the base?

Add ulimits to podman update #26445

Uh oh!

Conversation

aaron-ang commented Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Does this PR introduce a user-facing change?

Uh oh!

packit-as-a-service bot commented Jun 17, 2025

Uh oh!

packit-as-a-service bot commented Jun 17, 2025

Uh oh!

packit-as-a-service bot commented Jun 17, 2025

Uh oh!

Honny1 commented Jun 17, 2025

Uh oh!

Luap99 commented Jun 17, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aaron-ang commented Jun 18, 2025

Uh oh!

Luap99 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Luap99 commented Jun 18, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Honny1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aaron-ang commented Nov 19, 2025

Uh oh!

Honny1 commented Nov 20, 2025

Uh oh!

Honny1 Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

aaron-ang Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Honny1 left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Nov 24, 2025

Uh oh!

aaron-ang commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Add ulimits to `podman update` #26445

Add ulimits to `podman update` #26445

aaron-ang commented Jun 17, 2025 •

edited

Loading

aaron-ang commented Dec 16, 2025 •

edited

Loading