-
Notifications
You must be signed in to change notification settings - Fork 2.7k
quadlet: handle generate environment params that inherit from host #26322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: NotSoFancyName The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
faefd0b
to
8085ccc
Compare
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
we ask for tests on most of our PRs; the CI is blocking because it did not find a test included. I think this is something you probably should add a test for to protect against regressions. |
Thanks for the PR. |
Yeah right that is a good point. I think in general we should avoid input validation in quadlet as much as possible to avoid these kind of bugs so I am in favour of dropping these checks. If the input is invalid podman will still error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash the commits into one. As we want fixes and tests in the same commit.
code change itself LGTM
Fixes: containers#26247 Signed-off-by: Volodymyr Pankin <[email protected]>
d94cc22
to
2b6c477
Compare
Fixes: #26247
Does this PR introduce a user-facing change?