Skip to content

podman system check: Fix error check logic #26252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2025
Merged

podman system check: Fix error check logic #26252

merged 1 commit into from
Jun 2, 2025

Conversation

sonnysasaka
Copy link
Contributor

Previously there is a minor logic error, which causes podman system check to do the check twice although there is no repair flag.

Does this PR introduce a user-facing change?

None

@packit-as-a-service Packit-as-a-Service
Copy link

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

@Honny1 Honny1 added the No New Tests Allow PR to proceed without adding regression tests label Jun 2, 2025
Honny1
Honny1 reviewed Jun 2, 2025
View reviewed changes
Copy link
Member

@Honny1 Honny1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM changes.

@sonnysasaka, can you please check your commit signature?

@baude
Copy link
Member

baude commented Jun 2, 2025

yeah, consider a git commit --amend -s and force push again please

@sonnysasaka
podman system check: Fix error check logic
c87a761 
Previously there is a minor logic error, which causes podman system
check to do the check twice although there is no repair flag.

Signed-off-by: Sonny Sasaka <[email protected]>
@sonnysasaka
Copy link
Contributor Author

yeah, consider a git commit --amend -s and force push again please

Done, could you please take a look if this is okay? Thanks!

Luap99
Luap99 approved these changes Jun 2, 2025
View reviewed changes
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99, sonnysasaka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2025
@mheon
Copy link
Member

mheon commented Jun 2, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 2, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 226155e into containers:main Jun 2, 2025
72 of 77 checks passed
@Luap99 Luap99 mentioned this pull request Jun 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Honny1 Honny1 Honny1 left review comments

@Luap99 Luap99 Luap99 approved these changes

Assignees

@mheon mheon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. No New Tests Allow PR to proceed without adding regression tests release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sonnysasaka @baude @mheon @Honny1 @Luap99