Skip to content

bump image sfx #26120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 23 commits into from
Closed

Conversation

timcoding1988
Copy link
Collaborator

Does this PR introduce a user-facing change?


Copy link
Contributor

openshift-ci bot commented May 12, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@timcoding1988 timcoding1988 requested a review from Luap99 May 12, 2025 17:46
@openshift-ci openshift-ci bot added the do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None label May 12, 2025
Copy link
Contributor

openshift-ci bot commented May 12, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: timcoding1988
Once this PR has been reviewed and has the lgtm label, please assign mtrmac for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@timcoding1988 timcoding1988 requested a review from l0rd May 12, 2025 17:46
@Luap99
Copy link
Member

Luap99 commented May 12, 2025

Note DCO check is failing because your git config has the wrong name/author set.
Anyway please leave CI running here for now so we see if it finds any issues, the other thing is I like to include the date of the image build in the commit title so when scrolling through the git log it is more easy to spot the changes and we don't have a ton of commits with the same name and then also add the link to the automation_images PR as cross reference, i.e. a0acdb8

@Luap99
Copy link
Member

Luap99 commented May 12, 2025

@timcoding1988 timcoding1988 changed the title bump image suffix bump cached_image sfx May 12, 2025
@timcoding1988 timcoding1988 force-pushed the update_image_fix branch 2 times, most recently from ba22af1 to d0e85fd Compare May 12, 2025 20:28
@Luap99
Copy link
Member

Luap99 commented May 13, 2025

machine linux test on aarch64 keep timing out, that is not a good sign. Something in the updates packages seem to have causes a slow down. We were already close to 30 mins, i.e. around 26 mins but I rerun more than three times now so it is pretty consistent.

@timcoding1988 Can you add this to increase the timeout for the task.

diff --git a/.cirrus.yml b/.cirrus.yml
index 828b395c8c..ec47abe79b 100644
--- a/.cirrus.yml
+++ b/.cirrus.yml
@@ -796,7 +796,7 @@ podman_machine_aarch64_task:
     depends_on: *build
     ec2_instance:
         <<: *standard_build_ec2_aarch64
-    timeout_in: 30m
+    timeout_in: 40m
     env:
         TEST_FLAVOR: "machine-linux"
         EC2_INST_TYPE: c6g.metal

Hopefully it is just a bit above 30mins and not a hang or something.

@timcoding1988 timcoding1988 force-pushed the update_image_fix branch 2 times, most recently from 6ceaf22 to 8ff0804 Compare May 14, 2025 13:47
@TomSweeneyRedHat
Copy link
Member

The Fedora-41 root host boltdb failed with the below. It looks like it hung for 2 minutes trying to send a TERM signal. As everything else passed, including the test that had been problematic, I'm going to respin it.

 not ok 306 |450| podman run --tty -i failure with no tty in 123941ms
[+1076s] # tags: ci:parallel
[+1076s] # (from function `run_podman' in file test/system/helpers.bash, line 550,
[+1076s] #  in test file test/system/450-interactive.bats, line 103)
[+1076s] #   `run_podman run --tty -i=false --rm $IMAGE echo hello < /dev/null' failed
[+1076s] #
[+1076s] # [09:14:41.193391301] # /var/tmp/go/src/github.com/containers/podman/bin/podman run --tty -i --rm quay.io/libpod/testimage:20241011 echo hello
[+1076s] # [09:14:41.897298780] time="2025-05-14T09:14:41-05:00" level=warning msg="The input device is not a TTY. The --tty and --interactive flags might not work properly"
[+1076s] # hello
[+1076s] #
[+1076s] # [09:14:41.943781596] # /var/tmp/go/src/github.com/containers/podman/bin/podman run --tty -i --rm quay.io/libpod/testimage:20241011 echo hello
[+1076s] # [09:14:42.645672144] hello
[+1076s] #
[+1076s] # [09:14:42.696430000] # /var/tmp/go/src/github.com/containers/podman/bin/podman run --tty=false -i --rm quay.io/libpod/testimage:20241011 echo hello
[+1076s] # [09:14:44.167636642] hello
[+1076s] #
[+1076s] # [09:14:44.187945803] # /var/tmp/go/src/github.com/containers/podman/bin/podman run --tty -i=false --rm quay.io/libpod/testimage:20241011 echo hello
[+1076s] # 2025/05/14 09:14:50 socat[190207] W exiting on signal 15
[+1076s] # [09:16:44.215375796] hello
[+1076s] # timeout: sending signal TERM to command ‘/var/tmp/go/src/github.com/containers/podman/bin/podman’
[+1076s] # [09:16:44.223537401] [ rc=124 (** EXPECTED 0 **) ]
[+1076s] # *** TIMED OUT ***
[+1076s] # /var/tmp/go/src/github.com/containers/podman/test/system/450-interactive.bats: line 39: kill: (190203) - No such process
[+1076s] # # [teardown]

@Luap99 Luap99 marked this pull request as draft May 15, 2025 15:24
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 15, 2025
@timcoding1988 timcoding1988 changed the title bump cached_image sfx bump image sfx May 30, 2025
Copy link

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

Luap99 and others added 7 commits June 9, 2025 11:21
When a custom username is requested we must stil enable lingering for
it. The linger setup in the coreos image with the hard coded core user
doesn't really make sense as it doesn't work when another name is used.

Signed-off-by: Paul Holzinger <[email protected]>
There is no reason to deifne a dummy service to run sleep just to get
the podman.socket enabled. Enabeling a service is just creating the
symlink so we can do that for the user sessions as well.

Signed-off-by: Paul Holzinger <[email protected]>
This patch adds a new endpoint to the REST API called "artifacts" with
the following methods:
- Add
- Extract
- Inspect
- List
- Pull
- Push
- Remove

This API will be utilised by the Podman bindings to add OCI Artifact
support to our remote clients.

Jira: https://issues.redhat.com/browse/RUN-2711

Signed-off-by: Lewis Roy <[email protected]>
I noticed this was missing, its a simple 1 to 1 mapping to
--interface-name.

Signed-off-by: Paul Holzinger <[email protected]>
podman system check --quick currently only skips layer contents, but
practically it's not much quicker than without the flag.

This changes the flag to also skip checking layer digests which speed up
the check significantly.

In some cases, it is useful to opt for a quicker check if we prioritize
detecting and fixing severe corruption and can tolerate minor damage.

The check option is derived from CRI-O's internal repair:
https://github.com/cri-o/cri-o/blob/9e4d86d82370ad44c14649f28ebdd8f94aaa28ca/internal/lib/container_server.go#L860

Signed-off-by: Sonny Sasaka <[email protected]>
Users of WSL images currently get podman from the copr rpm on the
release PR with Epoch: 102. This is a problem if the user is looking to
update the image with packages from official Fedora repos.

This commit limits Epoch: 102 to only the podman rpms on
rhcontainerbot/podman-next copr. All other rpms, including other copr
rpms, will use the default Epoch.

Signed-off-by: Lokesh Mandvekar <[email protected]>
Luap99 and others added 14 commits June 9, 2025 11:21
We disabled it in the machine os image so it can no longer be used
currently.

Signed-off-by: Paul Holzinger <[email protected]>
Do not write /etc/environment.d files, something is broken in the new
image that causes the boot to fail when any basic var is set there.

Signed-off-by: Paul Holzinger <[email protected]>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
It has not been in use since commit f218f84 and should have been
removed there. It seems somehow it is causing a bug since our env file
is empty. In that case it triggers a segfault and since that happens
from within pam we are unable to login in any way.

I reported the issue[1] but because we don't need this just remove it so
we don't have to wait for a fix.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=2370858

Signed-off-by: Paul Holzinger <[email protected]>
This reverts commit 0b8dd90.

Signed-off-by: Paul Holzinger <[email protected]>
This is not used in the code so it can be deleted.

Signed-off-by: Paul Holzinger <[email protected]>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Two incomptable changes, they removed the BridgeNfIP6tables
and BridgeNfIptables fields so we must drop them. As they are not
important ones that should not cause problems.

Second, they moved to using DockerOCIImageConfig from another new module.
The json format did not chnage so this is not an external API break.

Signed-off-by: Paul Holzinger <[email protected]>
Includes one breaking change for the flag as BuildOutputs now accept a
slice.

Signed-off-by: Paul Holzinger <[email protected]>
Newer versions expect to use a new test helper.

Signed-off-by: Nalin Dahyabhai <[email protected]>
Signed-off-by: Paul Holzinger <[email protected]>
The buildah test code chnages so I had to manually resolve the conflict.

Signed-off-by: Paul Holzinger <[email protected]>
The --output option is not supported with remote.

Signed-off-by: Paul Holzinger <[email protected]>
Signed-off-by: Tim Zhou <[email protected]>
@github-actions github-actions bot added machine kind/api-change Change to remote API; merits scrutiny labels Jun 9, 2025
@Luap99
Copy link
Member

Luap99 commented Jun 10, 2025

you need to rebase against main and not merge main into your branch to avoid the history clutter

@timcoding1988 timcoding1988 deleted the update_image_fix branch June 11, 2025 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/api-change Change to remote API; merits scrutiny machine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants